Skip to content

Fixes for the NFSv4.2 READ_PLUS operation

[email protected] linux-nfs 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 0 repliesNew
  2. v116 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15SUNRPC: _shift_data_left/right_pages should check the shift lengthnet/sunrpc/xdr.c+12 -00 replies
2/15SUNRPC: Fixes for xdr_align_data()include/linux/sunrpc/xdr.h net/sunrpc/xdr.c+133 -430 replies
3/15SUNRPC: Fix xdr_expand_hole()include/linux/sunrpc/xdr.h net/sunrpc/xdr.c+180 -960 replies
4/15SUNRPC: Cleanup xdr_shrink_bufhead()net/sunrpc/xdr.c+87 -770 replies
5/15SUNRPC: _copy_to/from_pages() now check for zero lengthnet/sunrpc/xdr.c+2 -40 replies
6/15SUNRPC: Clean up open coded setting of the xdr_stream 'nwords' fieldnet/sunrpc/xdr.c+16 -130 replies
7/15SUNRPC: Cleanup - constify a number of xdr_buf helpersinclude/linux/sunrpc/xdr.h net/sunrpc/xdr.c+35 -400 replies
8/15SUNRPC: When expanding the buffer, we may need grow the sparse pagesnet/sunrpc/xdr.c+33 -20 replies
9/15NFSv4.2: Ensure we always reset the result->count in decode_read_plus()fs/nfs/nfs42xdr.c+1 -00 replies
10/15NFSv4.2: decode_read_plus_data() must skip padding after data segmentfs/nfs/nfs42xdr.c+3 -10 replies
11/15NFSv4.2: decode_read_plus_hole() needs to check the extent offsetfs/nfs/nfs42xdr.c+21 -30 replies
12/15NFSv4.2: Handle hole lengths that exceed the READ_PLUS read bufferfs/nfs/nfs42xdr.c+6 -00 replies
13/15NFSv4.2: Don't error when exiting early on a READ_PLUS buffer overflowfs/nfs/nfs42xdr.c+17 -190 replies
14/15NFSv4.2: Deal with potential READ_PLUS data extent buffer overflowfs/nfs/nfs42xdr.c+7 -20 replies
15/15NFSv4.2/pnfs: Don't use READ_PLUS with pNFS yetfs/nfs/nfs4proc.c+8 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/15] Fixes for the NFSv4.2 READ_PLUS operation

From: Trond Myklebust <[email protected]>

The patches are divided into two parts:
1) A set of SUNRPC patches to fix and clean up the XDR decoding operations that are used by READ_PLUS, READ and READDIR. The main focus is on the operations used to shift data left and right in pages.
2) A set of patches to the NFSv4.2 READ_PLUS client code. These mainly try to fix issues around bounds checking, but also fix at least one protocol conformance problem.

--
v2: - Fix corner cases when calling xdr_shrink_bufhead() and
xdr_shrink_pagelen() with shorter values of buf->len
- Fix xdr_buf helper functions to take a length parameter so we can optimise shorter values of buf->len more easily.
- Fix issues with sparse pages reported by Tigran
- Disable use of READ_PLUS in pNFS.
- Move nfsd patches into a separate series.

Trond Myklebust (15):
SUNRPC: _shift_data_left/right_pages should check the shift length
SUNRPC: Fixes for xdr_align_data()
SUNRPC: Fix xdr_expand_hole()
SUNRPC: Cleanup xdr_shrink_bufhead()
SUNRPC: _copy_to/from_pages() now check for zero length
SUNRPC: Clean up open coded setting of the xdr_stream 'nwords' field
SUNRPC: Cleanup - constify a number of xdr_buf helpers
SUNRPC: When expanding the buffer, we may need grow the sparse pages NFSv4.2: Ensure we always reset the result->count in
decode_read_plus()
NFSv4.2: decode_read_plus_data() must skip padding after data segment NFSv4.2: decode_read_plus_hole() needs to check the extent offset NFSv4.2: Handle hole lengths that exceed the READ_PLUS read buffer NFSv4.2: Don't error when exiting early on a READ_PLUS buffer overflow NFSv4.2: Deal with potential READ_PLUS data extent buffer overflow NFSv4.2/pnfs: Don't use READ_PLUS with pNFS yet

 fs/nfs/nfs42xdr.c          |  78 ++--
 fs/nfs/nfs4proc.c          |  15 +-
 include/linux/sunrpc/xdr.h |  26 +-
 net/sunrpc/xdr.c           | 735 ++++++++++++++++++++++++-------------
 4 files changed, 554 insertions(+), 300 deletions(-)
Signature · 1 line
2.29.2