treewide: start shaving off cruft for v2.0
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest14 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | bindings: cxx: check for error from gpiod_line_bulk_new()bindings/ bindings/ | +17 | 0 replies | |
| 2/14 | build: drop the message about tests having been built successfullytests/ | +0 | 0 replies | |
| 3/14 | core: export gpiod_is_gpiochip_device()include/ lib/ tests/ | +25 | 0 replies | |
| 4/14 | bulk: drop the limit on the max number of linesbindings/ bindings/ include/ +3 more | +18 | 0 replies | |
| 5/14 | core: drop line iteratorsbindings/ bindings/ bindings/ +6 more | +33 | 0 replies | |
| 6/14 | treewide: kill opening chips by labelbindings/ bindings/ bindings/ +5 more | +10 | 0 replies | |
| 7/14 | API: move gpiod_line_get_chip() to line attributes sectioninclude/ | +7 | 0 replies | |
| 8/14 | core: kill gpiod_line_close_chip()include/ lib/ | +0 | 0 replies | |
| 9/14 | core: kill gpiod_line_get()include/ lib/ tests/ | +0 | 0 replies | |
| 10/14 | treewide: kill global line lookupbindings/ bindings/ bindings/ +7 more | +26 | 0 replies | |
| 11/14 | treewide: kill find_lines()bindings/ bindings/ bindings/ +5 more | +0 | 0 replies | |
| 12/14 | core: rework gpiod_chip_find_line()bindings/ bindings/ bindings/ +7 more | +193 | 0 replies | |
| 13/14 | build: add a configure switch for building examplesbindings/ bindings/ configure.ac | +21 | 0 replies | |
| 14/14 | core: kill chip iteratorsbindings/ bindings/ bindings/ +23 more | +250 | 0 replies |
Reviews trailers per patch
None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andy Shevchenko |
|---|---|
| Series | R-b |
| 1/14 | |
| 2/14 | |
| 3/14 | |
| 4/14 | |
| 5/14 | |
| 6/14 | |
| 7/14 | |
| 8/14 | |
| 9/14 | |
| 10/14 | |
| 11/14 | |
| 12/14 | |
| 13/14 | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [libgpiod][PATCH 00/14] treewide: start shaving off cruft for v2.0
From: Bartosz Golaszewski <[email protected]>
The following series removes a lot of interfaces that were deemed overkill in libgpiod and the removal of which was suggested to me before proceeding with the new API.
This leaves a couple holes in the library but we'll follow them up with more improvements all over the tree. We'll create a new object called gpiod_request for dealing with line requests of arbitrary size. We'll probably remove the the bulk objects from bindings and eventually we'll switch to using the v2 kernel uAPI.
Andy - a note for you: I know you're always very thorough in your reviews but in this case let's consider this series preparing a construction zone for the new API. Please don't nitpick too much. :)
Bartosz Golaszewski (14):
bindings: cxx: check for error from gpiod_line_bulk_new()
build: drop the message about tests having been built successfully
core: export gpiod_is_gpiochip_device()
bulk: drop the limit on the max number of lines
core: drop line iterators
treewide: kill opening chips by label
API: move gpiod_line_get_chip() to line attributes section
core: kill gpiod_line_close_chip()
core: kill gpiod_line_get()
treewide: kill global line lookup
treewide: kill find_lines()
core: rework gpiod_chip_find_line()
build: add a configure switch for building examples
core: kill chip iterators
bindings/cxx/Makefile.am | 8 +- bindings/cxx/chip.cpp | 47 +-- bindings/cxx/examples/Makefile.am | 4 +- bindings/cxx/examples/gpiodetectcxx.cpp | 13 +- bindings/cxx/examples/gpiofindcxx.cpp | 18 +- bindings/cxx/examples/gpioinfocxx.cpp | 43 ++- bindings/cxx/gpiod.hpp | 147 +------- bindings/cxx/iter.cpp | 95 +---- bindings/cxx/line.cpp | 15 - bindings/cxx/line_bulk.cpp | 24 +- bindings/cxx/tests/tests-chip.cpp | 62 ++-- bindings/cxx/tests/tests-iter.cpp | 37 -- bindings/cxx/tests/tests-line.cpp | 19 - bindings/python/Makefile.am | 10 +- bindings/python/examples/gpiodetect.py | 12 +- bindings/python/examples/gpiofind.py | 15 +- bindings/python/examples/gpioinfo.py | 33 +- bindings/python/gpiodmodule.c | 473 +++++++----------------- bindings/python/tests/gpiod_py_test.py | 100 +---- configure.ac | 12 + include/gpiod.h | 258 ++----------- lib/Makefile.am | 2 +- lib/core.c | 12 +- lib/helpers.c | 176 +++------ lib/iter.c | 171 --------- tests/Makefile.am | 13 - tests/gpiod-test.h | 4 - tests/tests-bulk.c | 9 - tests/tests-chip.c | 97 +---- tests/tests-iter.c | 123 ------ tests/tests-line.c | 52 --- tools/gpiodetect.c | 29 +- tools/gpiofind.c | 34 +- tools/gpioinfo.c | 41 +- tools/gpiomon.c | 5 +- tools/tools-common.c | 15 + tools/tools-common.h | 3 + 37 files changed, 557 insertions(+), 1674 deletions(-) delete mode 100644 lib/iter.c delete mode 100644 tests/tests-iter.c
Signature · 1 line
2.29.1