Skip to content

xfs: don't drain buffer lru on freeze

Brian Foster linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: rename xfs_wait_buftarg() to xfs_buftarg_drain()fs/xfs/xfs_buf.c fs/xfs/xfs_buf.h fs/xfs/xfs_log.c +2 more+17 -172 replies
2/2xfs: don't drain buffer lru on freeze and read-only remountfs/xfs/xfs_buf.c fs/xfs/xfs_buf.h fs/xfs/xfs_log.c+20 -73 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchChandan Babu RDarrick J. Wong
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xfs: don't drain buffer lru on freeze

Hi all,

This series tweaks the xfs_log_quiesce() codepath to lift out the explicit buffer target LRU draining and isolate it to the unmount path. It's unnecessary to reclaim all buffers on filesystem freeze or read-only remount, and this also causes such operations to stall if a read heavy workload is running in parallel.

Patch 1 is a simple rename and patch 2 implements the functional change. Thoughts, reviews, flames appreciated.

Brian

Brian Foster (2):
xfs: rename xfs_wait_buftarg() to xfs_buftarg_drain()
xfs: don't drain buffer lru on freeze and read-only remount

 fs/xfs/xfs_buf.c   | 30 ++++++++++++++++++++----------
 fs/xfs/xfs_buf.h   | 11 ++++++-----
 fs/xfs/xfs_log.c   |  8 +++++---
 fs/xfs/xfs_mount.c |  4 ++--
 fs/xfs/xfs_trace.h |  2 +-
 5 files changed, 34 insertions(+), 21 deletions(-)
Signature · 1 line
2.26.2