Refactor generic fastboot_set_reboot_flag implementation
Get series with b4
b4 am 20201210165444.GW32272@bill-the-catVersions newest first
- v1 Latest1 of 7 patches 0 repliesNew
1 of 7 patches is in this archive. The cover letter announces 7.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 6/7 | Revert "fastboot: Add default fastboot_set_reboot_flag implementation" | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RESEND 0/7] Refactor generic fastboot_set_reboot_flag implementation
Quoted 39 lines · Eugeniu Rosca
Dear U-Boot maintainers,
Quoted 25 lines · Roman Kovalivskyi
Current generic implementation of
fastboot_set_reboot_flagis somewhat messy and requires some additional configuration option to be enabled besidesCMD_BCB, so it reverts that implementtion in order to bring a new cleaner one.New function called
bcb_set_reboot_reasonshould be exposed by BCB commands, so that all of the details could be put there instead of dealing with it in fastboot implementation directly. After that,fastboot_set_reboot_flagcould simply pass correct reboot reason string to the BCB implementation. IfCMD_BCBis disabled then the whole operation would return error code, which is no different behaviour than the current implementation.Eugeniu Rosca (5):
cmd: bcb: Extract '__bcb_load' from 'do_bcb_load' for internal needs
cmd: bcb: Extract '__bcb_set' from 'do_bcb_set' for internal needs
cmd: bcb: Extract '__bcb_store' from 'do_bcb_store' for internal needs
cmd: bcb: Expose 'bcb_write_reboot_reason' to external callers
cmd: bcb: Add support for processing const string literals inbcb_set()Roman Kovalivskyi (2):
Revert "fastboot: Add defaultfastboot_set_reboot_flagimplementation"
fastboot: Implement genericfastboot_set_reboot_flagQuoted 10 lines
cmd/bcb.c | 88 +++++++++++++++++++++++++++------- drivers/fastboot/Kconfig | 12 ----- drivers/fastboot/Makefile | 1 - drivers/fastboot/fb_bcb_impl.c | 43 ----------------- drivers/fastboot/fb_common.c | 12 ++++- include/bcb.h | 20 ++++++++ include/fastboot.h | 9 ---- 7 files changed, 101 insertions(+), 84 deletions(-) delete mode 100644 drivers/fastboot/fb_bcb_impl.c create mode 100644 include/bcb.h
Quoted 1 line
Any chance the patches will be applied?
I'll try and review at least the generic fastboot changes soon and if there's no problems, move this in to -next. Thanks.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201210/2e30749f/attachment.sig>