Skip to content

genirq: Treewide hunt for irq descriptor abuse and assorted fixes

Thomas Gleixner dri-devel intel-gfx linux-arm-kernel linux-gpio linux-parisc linux-pci linux-rdma linux-s390 lkml netdev ntb xen-devel 1 version Applied

Status from this message: The following commit has been merged into the irq/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest30 patches 43 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/30genirq: Move irq_has_action() into core codearch/alpha/kernel/sys_jensen.c arch/x86/kernel/topology.c include/linux/interrupt.h +2 more+21 -70 replies
2/30genirq: Move status flag checks to coreinclude/linux/irqdesc.h kernel/irq/manage.c+25 -122 replies
3/30genirq: Move irq_set_lockdep_class() to coreinclude/linux/irqdesc.h kernel/irq/irqdesc.c+18 -64 replies
4/30genirq: Provide irq_get_effective_affinity()include/linux/irq.h+7 -00 replies
5/30genirq: Annotate irq stats data raceskernel/irq/irqdesc.c kernel/irq/proc.c+5 -40 replies
6/30parisc/irq: Simplify irq count output for /proc/interruptsarch/parisc/kernel/irq.c+1 -40 replies
7/30genirq: Make kstat_irqs() staticinclude/linux/kernel_stat.h kernel/irq/irqdesc.c+6 -140 replies
8/30genirq: Provide kstat_irqdesc_cpu()include/linux/irqdesc.h kernel/irq/irqdesc.c+8 -20 replies
9/30ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()arch/arm/kernel/smp.c+1 -11 reply
10/30arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()arch/arm64/kernel/smp.c+1 -11 reply
11/30parisc/irq: Use irq_desc_kstat_cpu() in show_interrupts()arch/parisc/kernel/irq.c+1 -10 replies
12/30s390/irq: Use irq_desc_kstat_cpu() in show_msi_interrupt()arch/s390/kernel/irq.c+1 -11 reply
13/30drm/i915/lpe_audio: Remove pointless irq_to_desc() usagedrivers/gpu/drm/i915/display/intel_lpe_audio.c+0 -42 replies
14/30drm/i915/pmu: Replace open coded kstat_irqs() copydrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_pmu.c drivers/gpu/drm/i915/i915_pmu.h+43 -176 replies
15/30pinctrl: nomadik: Use irq_has_action()drivers/pinctrl/nomadik/pinctrl-nomadik.c+1 -21 reply
16/30mfd: ab8500-debugfs: Remove the racy fiddling with irq_descdrivers/mfd/ab8500-debugfs.c+3 -133 replies
17/30NTB/msi: Use irq_has_action()drivers/ntb/msi.c+1 -31 reply
18/30PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()drivers/pci/controller/pcie-xilinx-nwl.c+2 -61 reply
19/30PCI: mobiveil: Use irq_data_get_irq_chip_data()drivers/pci/controller/mobiveil/pcie-mobiveil-host.c+2 -61 reply
20/30net/mlx4: Replace irq_to_desc() abusedrivers/net/ethernet/mellanox/mlx4/en_cq.c drivers/net/ethernet/mellanox/mlx4/en_rx.c drivers/net/ethernet/mellanox/mlx4/mlx4_en.h+6 -111 reply
21/30net/mlx4: Use effective interrupt affinitydrivers/net/ethernet/mellanox/mlx4/en_cq.c+1 -11 reply
22/30net/mlx5: Replace irq_to_desc() abusedrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en_main.c drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c+3 -72 replies
23/30net/mlx5: Use effective interrupt affinitydrivers/net/ethernet/mellanox/mlx5/core/en_main.c+1 -12 replies
24/30xen/events: Remove unused bind_evtchn_to_irq_lateeoi()drivers/xen/events/events_base.c+0 -62 replies
25/30xen/events: Remove disfunct affinity spreadingdrivers/xen/events/events_base.c drivers/xen/evtchn.c+1 -420 replies
26/30xen/events: Use immediate affinity settingdrivers/xen/events/events_base.c+9 -260 replies
27/30xen/events: Only force affinity mask for percpu interruptsdrivers/xen/events/events_base.c+28 -1411 replies
28/30xen/events: Reduce irq_info::spurious_cnt storage sizedrivers/xen/events/events_base.c+5 -30 replies
29/30xen/events: Implement irq distributiondrivers/xen/events/events_base.c+64 -80 replies
30/30genirq: Remove export of irq_to_desc()kernel/irq/irqdesc.c+0 -10 replies

Reviews trailers per patch

14 of 30 patches have a Reviewed-by or Acked-by.

PatchVille SyrjäläHeiko CarstensLogan GunthorpeRob HerringLinus WalleijJani NikulaLee JonesMarc ZyngierTariq ToukanSaeed Mahameed
1/30
2/30
3/30
4/30
5/30
6/30
7/30
8/30
9/30A-b
10/30A-b
11/30
12/30A-b
13/30R-b A-b
14/30A-b
15/30R-b
16/30R-b A-b
17/30R-b
18/30R-b
19/30R-b
20/30R-b
21/30R-b
22/30R-b A-b
23/30R-b A-b
24/30
25/30
26/30
27/30
28/30
29/30
30/30

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v1 thread

Cover letter [patch 00/30] genirq: Treewide hunt for irq descriptor abuse and assorted fixes

A recent request to export kstat_irqs() pointed to a copy of the same in the i915 code, which made me look for further usage of irq descriptors in drivers.

The usage in drivers ranges from creative to broken in all colours.

irqdesc.h clearly says that this is core functionality and the fact C does not allow full encapsulation is not a justification to fiddle with it just because. It took us a lot of effort to make the core functionality provide what drivers need.

If there is a shortcoming, it's not asked too much to talk to the relevant maintainers instead of going off and fiddling with the guts of interrupt descriptors and often enough without understanding lifetime and locking rules.

As people insist on not respecting boundaries, this series cleans up the (ab)use and at the end removes the export of irq_to_desc() to make it at least harder. All legitimate users of this are built in.

While at it I stumbled over some other oddities related to interrupt counting and cleaned them up as well.

The series applies on top of

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core

and is also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git genirq

Thanks,

tglx

---
 arch/alpha/kernel/sys_jensen.c                       |    2 
 arch/arm/kernel/smp.c                                |    2 
 arch/parisc/kernel/irq.c                             |    7 
 arch/s390/kernel/irq.c                               |    2 
 arch/x86/kernel/topology.c                           |    1 
 arch/arm64/kernel/smp.c                              |    2 
 drivers/gpu/drm/i915/display/intel_lpe_audio.c       |    4 
 drivers/gpu/drm/i915/i915_irq.c                      |   34 +++
 drivers/gpu/drm/i915/i915_pmu.c                      |   18 -
 drivers/gpu/drm/i915/i915_pmu.h                      |    8 
 drivers/mfd/ab8500-debugfs.c                         |   16 -
 drivers/net/ethernet/mellanox/mlx4/en_cq.c           |    8 
 drivers/net/ethernet/mellanox/mlx4/en_rx.c           |    6 
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h         |    3 
 drivers/net/ethernet/mellanox/mlx5/core/en.h         |    2 
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c    |    2 
 drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c    |    6 
 drivers/ntb/msi.c                                    |    4 
 drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |    8 
 drivers/pci/controller/pcie-xilinx-nwl.c             |    8 
 drivers/pinctrl/nomadik/pinctrl-nomadik.c            |    3 
 drivers/xen/events/events_base.c                     |  172 +++++++++++--------
 drivers/xen/evtchn.c                                 |   34 ---
 include/linux/interrupt.h                            |    1 
 include/linux/irq.h                                  |    7 
 include/linux/irqdesc.h                              |   40 +---
 include/linux/kernel_stat.h                          |    1 
 kernel/irq/irqdesc.c                                 |   42 ++--
 kernel/irq/manage.c                                  |   37 ++++
 kernel/irq/proc.c                                    |    5 
 30 files changed, 263 insertions(+), 222 deletions(-)