Skip to content

ceph: don't call ceph_check_caps in page_mkwrite

Jeff Layton ceph-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ceph: fix flush_snap logic after putting capsfs/ceph/caps.c+6 -40 replies
2/3ceph: clean up inode work queueingfs/ceph/inode.c fs/ceph/super.h+24 -522 replies
3/3ceph: allow queueing cap/snap handling after putting cap referencesfs/ceph/addr.c fs/ceph/caps.c fs/ceph/inode.c +1 more+47 -82 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] ceph: don't call ceph_check_caps in page_mkwrite

I've been working on the fscache rework, and have hit some rather complex lockdep circular locking warnings. Most of them involve two filesystems (cephfs and the local cachefiles fs), so it's not clear to me whether they are false positives.

They do involve the mmap_lock though, which is taken up in the vfs. I think it would probably be best to not do the ceph_check_caps call with that lock held if we can avoid it.

The first patch in this series fixes what looks like a probable bug to me. If we want to avoid checking caps in some cases, then we probably also want to avoid flushing the snaps too since that involves the same locks.

The second patch replaces the patch that I sent a few weeks ago to add a queue_inode_work helper.

The last patch extends some work that Xiubo did earlier to allow skipping the caps check after putting references. It adds a new "flavor" when putting caps that instead has the inode work do the check or flush after the refcounts have been decremented.

Jeff Layton (3):
ceph: fix flush_snap logic after putting caps
ceph: clean up inode work queueing
ceph: allow queueing cap/snap handling after putting cap references

 fs/ceph/addr.c  |  2 +-
 fs/ceph/caps.c  | 36 +++++++++++++++++++++++------
 fs/ceph/inode.c | 61 ++++++++++---------------------------------------
 fs/ceph/super.h | 40 +++++++++++++++++++++++++++-----
 4 files changed, 76 insertions(+), 63 deletions(-)
Signature · 1 line
2.29.2