Skip to content

intel driver cleanups

Maciej Fijalkowski bpf intel-wired-lan netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 3 repliesIn review
  2. v28 patches 0 repliesSuperseded
  3. v18 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11i40e: drop redundant check when setting xdp progdrivers/net/ethernet/intel/i40e/i40e_main.c+0 -30 replies
2/11i40e: drop misleading function commentsdrivers/net/ethernet/intel/i40e/i40e_txrx.c+6 -270 replies
3/11i40e: adjust i40e_is_non_eopdrivers/net/ethernet/intel/i40e/i40e_txrx.c+6 -170 replies
4/11ice: simplify ice_run_xdpdrivers/net/ethernet/intel/ice/ice_txrx.c+5 -100 replies
5/11ice: move skb pointer from rx_buf to rx_ringdrivers/net/ethernet/intel/ice/ice_txrx.c drivers/net/ethernet/intel/ice/ice_txrx.h+14 -181 reply
6/11ice: remove redundant checks in ice_change_mtudrivers/net/ethernet/intel/ice/ice_main.c+0 -91 reply
7/11ice: skip NULL check against XDP prog in ZC pathdrivers/net/ethernet/intel/ice/ice_xsk.c+3 -40 replies
8/11i40e, xsk: Simplify the do-while allocation loopdrivers/net/ethernet/intel/i40e/i40e_xsk.c+1 -30 replies
9/11i40e: store the result of i40e_rx_offset() onto i40e_ringdrivers/net/ethernet/intel/i40e/i40e_txrx.c drivers/net/ethernet/intel/i40e/i40e_txrx.h+19 -170 replies
10/11ice: store the result of ice_rx_offset() onto ice_ringdrivers/net/ethernet/intel/ice/ice_txrx.c drivers/net/ethernet/intel/ice/ice_txrx.h+23 -211 reply
11/11ixgbe: store the result of ixgbe_rx_offset() onto ixgbe_ringdrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+9 -70 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchBjörn TöpelMaciej FijalkowskiTony Brelinski
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b R-b T-b
6/11R-b R-b T-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b R-b T-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 net-next 00/11] intel driver cleanups

Hi,

This series is mostly about the cleanups on Rx (ZC/normal) paths both in ice and i40e drivers. Things that stand out are the simplifactions of ice_change_mtu and i40e_xdp_setup.

Third iteration of this includes patches that optimize the handling of *_rx_offset() calls per each processed frame. Some cycles can be saved by storing the result of that function onto rx ring. For that, I am using existing holes within ring structs (checked with pahole).

Thanks!

v3: rebase, fix handling rx offset
v2: fix kdoc in patch 5 (Jakub)

Bj?rn T?pel (1):
i40e, xsk: Simplify the do-while allocation loop

Maciej Fijalkowski (10):
i40e: drop redundant check when setting xdp prog
i40e: drop misleading function comments
i40e: adjust i40e_is_non_eop
ice: simplify ice_run_xdp
ice: move skb pointer from rx_buf to rx_ring
ice: remove redundant checks in ice_change_mtu
ice: skip NULL check against XDP prog in ZC path
i40e: store the result of i40e_rx_offset() onto i40e_ring
ice: store the result of ice_rx_offset() onto ice_ring
ixgbe: store the result of ixgbe_rx_offset() onto ixgbe_ring

 drivers/net/ethernet/intel/i40e/i40e_main.c   |  3 -
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   | 91 ++++++-------------
 drivers/net/ethernet/intel/i40e/i40e_txrx.h   |  1 +
 drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  4 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |  9 --
 drivers/net/ethernet/intel/ice/ice_txrx.c     | 88 ++++++++----------
 drivers/net/ethernet/intel/ice/ice_txrx.h     |  3 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c      |  7 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  1 +
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 15 +--
 10 files changed, 86 insertions(+), 136 deletions(-)
Signature · 1 line
2.20.1