Immutable QString, and also one JSON writer less
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest20 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | hmp: Simplify how qmp_human_monitor_command() gets outputmonitor/ | +1 | 1 reply | |
| 2/20 | monitor: Use GString instead of QString for output buffermonitor/ monitor/ monitor/ | +10 | 1 reply | |
| 3/20 | qobject: Make qobject_to_json_pretty() take a pretty argumentinclude/ monitor/ qemu-img.c +3 more | +19 | 0 replies | |
| 4/20 | qobject: Use GString instead of QString to accumulate JSONinclude/ qobject/ qobject/ | +58 | 0 replies | |
| 5/20 | qobject: Change qobject_to_json()'s value to GStringblock.c block/ include/ +9 more | +79 | 2 replies | |
| 6/20 | Revert "qstring: add qstring_free()"include/ qobject/ | +5 | 0 replies | |
| 7/20 | hw/rdma: Replace QList by GQueuehw/ hw/ hw/ +1 more | +30 | 0 replies | |
| 8/20 | qobject: Move internals to qobject-internal.hinclude/ include/ include/ +12 more | +47 | 0 replies | |
| 9/20 | qmp: Fix tracing of non-string command IDsmonitor/ | +18 | 0 replies | |
| 10/20 | block: Avoid qobject_get_try_str()block.c | +3 | 1 reply | |
| 11/20 | Revert "qobject: let object_property_get_str() use new API"qom/ | +6 | 1 reply | |
| 12/20 | qobject: Drop qobject_get_try_str()include/ qobject/ | +0 | 0 replies | |
| 13/20 | qobject: Drop qstring_get_try_str()include/ qobject/ tests/ | +5 | 0 replies | |
| 14/20 | qobject: Factor quoted_str() out of to_json()qobject/ | +54 | 0 replies | |
| 15/20 | qobject: Factor JSON writer out of qobject_to_json()include/ qobject/ qobject/ +2 more | +318 | 0 replies | |
| 16/20 | migration: Replace migration's JSON writer by the general onehw/ hw/ hw/ +26 more | +114 | 4 replies | |
| 17/20 | json: Use GString instead of QString to accumulate stringsqobject/ | +15 | 0 replies | |
| 18/20 | keyval: Use GString to accumulate value stringsutil/ | +6 | 3 replies | |
| 19/20 | block: Use GString instead of QString to build filenamesblock.c | +6 | 1 reply | |
| 20/20 | qobject: Make QString immutableinclude/ qobject/ tests/ +1 more | +4 | 0 replies |
Reviews trailers per patch
6 of 20 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy | Eduardo Habkost | Dr. David Alan Gilbert |
|---|---|---|---|
| 1/20 | R-b | ||
| 2/20 | R-b | ||
| 3/20 | |||
| 4/20 | |||
| 5/20 | |||
| 6/20 | |||
| 7/20 | |||
| 8/20 | |||
| 9/20 | |||
| 10/20 | R-b | ||
| 11/20 | R-b | ||
| 12/20 | |||
| 13/20 | |||
| 14/20 | |||
| 15/20 | |||
| 16/20 | R-b | ||
| 17/20 | |||
| 18/20 | |||
| 19/20 | R-b | ||
| 20/20 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/20] Immutable QString, and also one JSON writer less
Based-on: <[email protected]>
Markus Armbruster (20):
hmp: Simplify how qmp_human_monitor_command() gets output
monitor: Use GString instead of QString for output buffer
qobject: Make qobject_to_json_pretty() take a pretty argument
qobject: Use GString instead of QString to accumulate JSON
qobject: Change qobject_to_json()'s value to GString Revert "qstring: add qstring_free()"
hw/rdma: Replace QList by GQueue
qobject: Move internals to qobject-internal.h
qmp: Fix tracing of non-string command IDs
block: Avoid qobject_get_try_str()
Revert "qobject: let object_property_get_str() use new API"
qobject: Drop qobject_get_try_str()
qobject: Drop qstring_get_try_str()
qobject: Factor quoted_str() out of to_json()
qobject: Factor JSON writer out of qobject_to_json()
migration: Replace migration's JSON writer by the general one
json: Use GString instead of QString to accumulate strings
keyval: Use GString to accumulate value strings
block: Use GString instead of QString to build filenames
qobject: Make QString immutable
hw/rdma/rdma_backend_defs.h | 2 +- hw/rdma/rdma_utils.h | 15 +- include/migration/vmstate.h | 7 +- include/qapi/qmp/json-writer.h | 35 ++++ include/qapi/qmp/qbool.h | 2 - include/qapi/qmp/qdict.h | 2 - include/qapi/qmp/qjson.h | 4 +- include/qapi/qmp/qlist.h | 2 - include/qapi/qmp/qnull.h | 2 - include/qapi/qmp/qnum.h | 3 - include/qapi/qmp/qobject.h | 9 +- include/qapi/qmp/qstring.h | 14 +- include/qemu/typedefs.h | 4 +- migration/qjson.h | 29 ---- monitor/monitor-internal.h | 2 +- qobject/qobject-internal.h | 39 +++++ block.c | 23 +-- block/rbd.c | 2 +- hw/display/virtio-gpu.c | 2 +- hw/intc/s390_flic_kvm.c | 2 +- hw/nvram/eeprom93xx.c | 2 +- hw/nvram/fw_cfg.c | 2 +- hw/pci/msix.c | 2 +- hw/pci/pci.c | 4 +- hw/pci/shpc.c | 2 +- hw/rdma/rdma_backend.c | 10 +- hw/rdma/rdma_utils.c | 29 ++-- hw/rtc/twl92230.c | 2 +- hw/scsi/scsi-bus.c | 2 +- hw/usb/redirect.c | 7 +- hw/virtio/virtio.c | 4 +- migration/qjson.c | 114 ------------- migration/savevm.c | 53 ++++--- migration/vmstate-types.c | 38 ++--- migration/vmstate.c | 52 +++--- monitor/misc.c | 6 +- monitor/monitor.c | 20 +-- monitor/qmp.c | 46 +++--- qemu-img.c | 33 ++-- qga/main.c | 22 +-- qobject/json-parser.c | 30 ++-- qobject/json-writer.c | 247 +++++++++++++++++++++++++++++ qobject/qbool.c | 1 + qobject/qdict.c | 1 + qobject/qjson.c | 144 ++++------------- qobject/qlist.c | 1 + qobject/qnull.c | 1 + qobject/qnum.c | 6 +- qobject/qobject.c | 1 + qobject/qstring.c | 117 +++----------- qom/object.c | 9 +- qom/object_interfaces.c | 4 +- qom/qom-hmp-cmds.c | 7 +- target/alpha/machine.c | 2 +- target/arm/machine.c | 6 +- target/avr/machine.c | 4 +- target/hppa/machine.c | 4 +- target/microblaze/machine.c | 2 +- target/mips/machine.c | 4 +- target/openrisc/machine.c | 2 +- target/ppc/machine.c | 10 +- target/sparc/machine.c | 2 +- tests/check-qjson.c | 67 ++++---- tests/check-qobject.c | 3 +- tests/check-qstring.c | 16 -- tests/qtest/libqtest.c | 20 ++- tests/test-visitor-serialization.c | 6 +- util/keyval.c | 11 +- migration/meson.build | 1 - qobject/meson.build | 5 +- 70 files changed, 679 insertions(+), 705 deletions(-) create mode 100644 include/qapi/qmp/json-writer.h delete mode 100644 migration/qjson.h create mode 100644 qobject/qobject-internal.h delete mode 100644 migration/qjson.c create mode 100644 qobject/json-writer.c
Signature · 1 line
2.26.2