Skip to content

Broadcom's PMB (Power Management Bus) support

Rafał Miłecki linux-devicetree lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesIn review
  2. v12 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: power: document Broadcom's PMB bindingDocumentation/devicetree/bindings/power/brcm,bcm-pmb.yaml include/dt-bindings/soc/bcm-pmb.h+61 -03 replies
2/2soc: bcm: add PM driver for Broadcom's PMBMAINTAINERS drivers/soc/bcm/Makefile drivers/soc/bcm/bcm63xx/Kconfig +2 more+354 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringFlorian FainelliUlf Hansson
1/2R-b A-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH V2 0/2] Broadcom's PMB (Power Management Bus) support

From: Rafał Miłecki <[email protected]>

PMB is a hardware block used for powering SoC devices like PCIe, USB, SATA. Initially I planned to treat it as a reset controller and Philipp pointed out in review that PMB driver should use a power subsystem.

This is my refactored support.

***

Please note one difference when compared to the initial reset attempt.

As I store info about SoC devices in the driver now, I had to put support for multiple buses there. That's required to avoid things like:

compatible = "brcm,bcm4908-pmb-no-1";
compatible = "brcm,bcm4908-pmb-no-2";

So now a single "reg" covers bigger buses (e.g. 0x40) in size, see:

reg = <0x802800e0 0x40>;

Other SoCs my use something like:

reg = <0x802800e0 0x20>;
reg = <0x802800e0 0x60>;

***

AFAIU this should go through Florian's tree. I based in on top of the soc-arm64/next.

V2: Use drivers/soc/bcm/bcm63xx/ and add Kconfig help message

Rafał Miłecki (2):
dt-bindings: power: document Broadcom's PMB binding
soc: bcm: add PM driver for Broadcom's PMB

 .../bindings/power/brcm,bcm-pmb.yaml          |  50 +++
 MAINTAINERS                                   |  10 +
 drivers/soc/bcm/Makefile                      |   2 +-
 drivers/soc/bcm/bcm63xx/Kconfig               |   9 +
 drivers/soc/bcm/bcm63xx/Makefile              |   1 +
 drivers/soc/bcm/bcm63xx/bcm-pmb.c             | 333 ++++++++++++++++++
 include/dt-bindings/soc/bcm-pmb.h             |  11 +
 7 files changed, 415 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/power/brcm,bcm-pmb.yaml
 create mode 100644 drivers/soc/bcm/bcm63xx/bcm-pmb.c
 create mode 100644 include/dt-bindings/soc/bcm-pmb.h
Signature · 1 line
2.26.2