Skip to content

hw/ppc: Convert UIC device to QOM

Peter Maydell qemu-devel 2 versions – Applied

Status from this message: Applied to ppc-for-6.0, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesApplied
  2. v18 patches 30 repliesApplied

Changes in v2 from the cover letter

* fixed the bug in the sam460ex conversion handling of CINT (tested that this now boots AROS OK to a desktop)
* other minor code style tweaks to patch 1 as per review

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4hw/ppc/sam460ex: Drop use of ppcuic_init()hw/ppc/sam460ex.c+53 -161 reply
2/4hw/ppc: Delete unused ppc405cr_init() codehw/ppc/ppc405.h hw/ppc/ppc405_uc.c+0 -3510 replies
3/4hw/ppc/ppc405_uc: Drop use of ppcuic_init()hw/ppc/ppc405.h hw/ppc/ppc405_boards.c hw/ppc/ppc405_uc.c+47 -330 replies
4/4hw/ppc: Remove unused ppcuic_init()hw/ppc/ppc4xx_devs.c include/hw/intc/ppc-uic.h include/hw/ppc/ppc4xx.h+7 -470 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchEdgar E. IglesiasBALATON Zoltan
1/4R-b
2/4
3/4
4/4R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] hw/ppc: Convert UIC device to QOM

This patchseries converts the PPC UIC "Universal Interrupt Controller" to a QOM device. My main reason for doing it is that this fixes a couple of long-standing trivial Coverity issues -- the current ppcuic_init() function allocates an array of qemu_irqs which the callers then leak. (The leak is trivial because it happens once when QEMU starts.)

The first half of v1 is in master now, so this is just a respin of the last four patches.

Changes v1->v2:
* fixed the bug in the sam460ex conversion handling of CINT (tested that this now boots AROS OK to a desktop)
* other minor code style tweaks to patch 1 as per review

thanks
-- PMM

Peter Maydell (4):
hw/ppc/sam460ex: Drop use of ppcuic_init()
hw/ppc: Delete unused ppc405cr_init() code
hw/ppc/ppc405_uc: Drop use of ppcuic_init()
hw/ppc: Remove unused ppcuic_init()

 hw/ppc/ppc405.h           |   8 +-
 include/hw/intc/ppc-uic.h |   7 +
 include/hw/ppc/ppc4xx.h   |   9 -
 hw/ppc/ppc405_boards.c    |   8 +-
 hw/ppc/ppc405_uc.c        | 415 ++++----------------------------------
 hw/ppc/ppc4xx_devs.c      |  38 ----
 hw/ppc/sam460ex.c         |  69 +++++--
 7 files changed, 107 insertions(+), 447 deletions(-)
Signature · 1 line
2.20.1