xt-monitor fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | xtables-monitor: fix rule printingiptables/ | +15 | 1 reply | |
| 2/3 | xtables-monitor: fix packet family protocoliptables/ | +2 | 0 replies | |
| 3/3 | xtables-monitor: print packet firstiptables/ | +23 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH xtables-nft 0/3] xt-monitor fixes
rule tracing via xt-monitor has various bugs:
1. It prints unrelated rules because the function supposed
to print the traced rule does a dump instead of a handle lookup. This prints all rules in the chain instead of just one.
2. Print the table family, not whatever family user provided on command line.
3. The packet shoud be printed first, instead of after the first trace event.
4. also make sure to flush stdout after each event so stdout redirect to files/pipes etc. works.
After this the output is much more similar to nft monitor, just in xt rule format.
Florian Westphal (3):
xtables-monitor: fix rule printing
xtables-monitor: fix packet family protocol
xtables-monitor: print packet first
iptables/xtables-monitor.c | 70 ++++++++++++++++++++++---------------- 1 file changed, 40 insertions(+), 30 deletions(-)
Signature · 1 line
2.28.0