Skip to content

xt-monitor fixes

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xtables-monitor: fix rule printingiptables/xtables-monitor.c+15 -171 reply
2/3xtables-monitor: fix packet family protocoliptables/xtables-monitor.c+2 -20 replies
3/3xtables-monitor: print packet firstiptables/xtables-monitor.c+23 -112 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH xtables-nft 0/3] xt-monitor fixes

rule tracing via xt-monitor has various bugs:
1. It prints unrelated rules because the function supposed
to print the traced rule does a dump instead of a handle lookup. This prints all rules in the chain instead of just one.
2. Print the table family, not whatever family user provided on command line.
3. The packet shoud be printed first, instead of after the first trace event.
4. also make sure to flush stdout after each event so stdout redirect to files/pipes etc. works.

After this the output is much more similar to nft monitor, just in xt rule format.

Florian Westphal (3):
xtables-monitor: fix rule printing
xtables-monitor: fix packet family protocol
xtables-monitor: print packet first

 iptables/xtables-monitor.c | 70 ++++++++++++++++++++++----------------
 1 file changed, 40 insertions(+), 30 deletions(-)
Signature · 1 line
2.28.0