Skip to content

KVM/ARM: Some vgic fixes and init sequence KVM selftests

Eric Auger kvm kvmarm lkml 6 versions – Applied

Status from this message: Applied to kvm-arm64/vgic-5.13, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest9 patches 5 repliesApplied
  2. v58 patches 4 repliesSuperseded
  3. v48 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v38 patches2 repliesSuperseded
v29 patches0 repliesSuperseded
v19 patches23 repliesSuperseded

Changes in v6 from the cover letter

- Fix the note in "KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace", confirming the rdist region list is sorted by index and not by base address.
- Properly send 9 patches :-/

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/9KVM: arm64: vgic-v3: Fix some error codes when setting RDIST basearch/arm64/kvm/vgic/vgic-mmio-v3.c+7 -70 replies
2/9KVM: arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION readarch/arm64/kvm/vgic/vgic-kvm-device.c+3 -00 replies
3/9KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base()arch/arm64/kvm/vgic/vgic-mmio-v3.c+7 -10 replies
4/9KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy()arch/arm64/kvm/vgic/vgic-init.c+5 -10 replies
5/9docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT docDocumentation/virt/kvm/devices/arm-vgic-v3.rst+1 -10 replies
6/9KVM: arm64: Simplify argument passing to vgic_uaccess_[read|write]arch/arm64/kvm/vgic/vgic-mmio.c+4 -60 replies
7/9kvm: arm64: vgic-v3: Introduce vgic_v3_free_redist_region()arch/arm64/kvm/vgic/vgic-init.c arch/arm64/kvm/vgic/vgic-mmio-v3.c arch/arm64/kvm/vgic/vgic.h+14 -100 replies
8/9KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspacearch/arm64/kvm/vgic/vgic-mmio-v3.c include/kvm/arm_vgic.h+34 -250 replies
9/9KVM: selftests: aarch64/vgic-v3 init sequence teststools/testing/selftests/kvm/.gitignore tools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/aarch64/vgic_init.c +2 more+673 -04 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchAlexandru Elisei
1/9
2/9R-b
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/9] KVM/ARM: Some vgic fixes and init sequence KVM selftests

While writting vgic v3 init sequence KVM selftests I noticed some relatively minor issues. This was also the opportunity to try to fix the issue laterly reported by Zenghui, related to the RDIST_TYPER last bit emulation. The final patch is a first batch of VGIC init sequence selftests. Of course they can be augmented with a lot more register access tests, but let's try to move forward incrementally ...

Best Regards

Eric

This series can be found at:
https://github.com/eauger/linux/tree/vgic_kvmselftests_v6

History:

v5 -> v6:
- Fix the note in "KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace", confirming the rdist region list is sorted by index and not by base address.
- Properly send 9 patches :-/

v4 -> v5:
- rewrite the last bit detection according to Marc's interpretation of the spec and modify the kvm selftests accordingly
v3 -> v4:
- take into account Drew's comment on the kvm selftests. No change to the KVM related patches compared to v3
v2 ->v3:
- reworked last bit read accessor to handle contiguous redist regions and rdist not registered in ascending order
- removed [PATCH 5/9] KVM: arm: move has_run_once after the map_resources
v1 -> v2:
- Took into account all comments from Marc and Alexandru's except the has_run_once still after the map_resources (this would oblige me to revisit in depth the selftests)

Eric Auger (9):
KVM: arm64: vgic-v3: Fix some error codes when setting RDIST base
KVM: arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION read
KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base()
KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy()
docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc
KVM: arm64: Simplify argument passing to vgic_uaccess_[read|write]
kvm: arm64: vgic-v3: Introduce vgic_v3_free_redist_region()
KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace
KVM: selftests: aarch64/vgic-v3 init sequence tests

 .../virt/kvm/devices/arm-vgic-v3.rst          |   2 +-
 arch/arm64/kvm/vgic/vgic-init.c               |  12 +-
 arch/arm64/kvm/vgic/vgic-kvm-device.c         |   3 +
 arch/arm64/kvm/vgic/vgic-mmio-v3.c            |  93 +--
 arch/arm64/kvm/vgic/vgic-mmio.c               |  10 +-
 arch/arm64/kvm/vgic/vgic.h                    |   1 +
 include/kvm/arm_vgic.h                        |   1 +
 tools/testing/selftests/kvm/.gitignore        |   1 +
 tools/testing/selftests/kvm/Makefile          |   1 +
 .../testing/selftests/kvm/aarch64/vgic_init.c | 585 ++++++++++++++++++
 .../testing/selftests/kvm/include/kvm_util.h  |   9 +
 tools/testing/selftests/kvm/lib/kvm_util.c    |  77 +++
 12 files changed, 746 insertions(+), 49 deletions(-)
 create mode 100644 tools/testing/selftests/kvm/aarch64/vgic_init.c
Signature · 1 line
2.26.3