Skip to content

pmdinfogen: support Windows

Dmitry Kozlyuk dpdk-dev 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesApplied
  2. v14 patches 0 repliesSuperseded

Changes in v2 from the cover letter

Don't require elftools on Windows (Jie Zhou).

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4pmdinfogen: support COFFbuildtools/coff.py buildtools/meson.build buildtools/pmdinfogen.py+248 -300 replies
2/4pmdinfogen: allow multiple input filesbuildtools/pmdinfogen.py+9 -40 replies
3/4buildtools: support object file extraction for Windowsbuildtools/gen-pmdinfo-cfile.py buildtools/gen-pmdinfo-cfile.sh buildtools/meson.build +1 more+34 -161 reply
4/4build: enable pmdinfogen for Windowsdrivers/meson.build+12 -141 reply

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchJie Zhou
1/4
2/4
3/4
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/4] pmdinfogen: support Windows

Based on Python version of pmdinfogen, deferred until 21.02:

    http://patchwork.dpdk.org/project/dpdk/list/?series=13153

There are a few Python libraries for PE/COFF, none of which suits the need, so a custom COFF parser is used. Advice is welcome, options considered:

* py-coff (https://github.com/jeppeter/py-coff): doesn't give access to symbol values, Python 2 code inside, not very popular.

* pefile (https://github.com/erocarrera/pefile): for PE (executables and libraries), not COFF (objects); most popular.

* pype32-py3 (https://github.com/crackinglandia/pype32): ditto, less popular.

A script to extract object files from library is still required. Meson has extract_all_objects(), but they can't be passed as inputs to custom_target() until 0.52.0 (commit f431cff809).

v2:
Don't require elftools on Windows (Jie Zhou).

Dmitry Kozlyuk (4):
pmdinfogen: support COFF
pmdinfogen: allow multiple input files
buildtools: support object file extraction for Windows
build: enable pmdinfogen for Windows

 buildtools/coff.py              | 154 ++++++++++++++++++++++++++++++++
 buildtools/gen-pmdinfo-cfile.py |  19 ++++
 buildtools/gen-pmdinfo-cfile.sh |  14 ---
 buildtools/meson.build          |  15 +++-
 buildtools/pmdinfogen.py        | 135 +++++++++++++++++++++-------
 drivers/meson.build             |  26 +++---
 6 files changed, 301 insertions(+), 62 deletions(-)
 create mode 100644 buildtools/coff.py
 create mode 100644 buildtools/gen-pmdinfo-cfile.py
 delete mode 100755 buildtools/gen-pmdinfo-cfile.sh
Signature · 1 line
2.29.2