Skip to content

add support for the lmk04832

Liam Beguin linux-clk linux-devicetree lkml 5 versions – Applied

Status from this message: Applied to clk-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 5 repliesApplied
  2. v43 patches 3 repliesSuperseded
  3. v33 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches2 repliesSuperseded
v1 RFC1 patch1 replySuperseded

Changes since v1 from the cover letter

- add yaml devicetree documentation,
- add links to datasheet,
- use {u8,u16,u32} instead of Uint_ variants,
- drop redundant debugfs code,
- use a pointer to device_info instead of struct copy,
- add of_device_id table,
- add support for SYSREF digital delay and JESD204B subclass 1

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/3clk: add support for the lmk04832drivers/clk/Kconfig drivers/clk/Makefile drivers/clk/clk-lmk04832.c+1295 -01 reply
2/3clk: lmk04832: add support for digital delaydrivers/clk/clk-lmk04832.c+315 -61 reply
3/3dt-bindings: clock: add ti,lmk04832 bindingsDocumentation/devicetree/bindings/clock/ti,lmk04832.yaml+209 -02 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] add support for the lmk04832

From: Liam Beguin <[email protected]>

Hi,

The LMK04832 is an ultra-high performance clock conditioner with JEDEC JESD204B support and is also pin compatible with the LMK0482x family of devices.

This driver adds initial support to configure the LMK04832 clocks using the clock framework.

This has been tested on a system using JESD204B subclass 1.

At the moment, the VCO rate has to be set manually from the devicetree and a dclk (or sclk) rate change isn't propagated to the VCO automatically.

Changes since v1:
- add yaml devicetree documentation,
- add links to datasheet,
- use {u8,u16,u32} instead of Uint_ variants,
- drop redundant debugfs code,
- use a pointer to device_info instead of struct copy,
- add of_device_id table,
- add support for SYSREF digital delay and JESD204B subclass 1

Changes since v2:
- fix dt-bindings documentation, apologies for the broken build
- fix property vendor prefixes
- split dt-bindings into a separate patch

Changes since v3:
- add missing properties in dt-bindings

Changes since v3:
- address coccicheck comments
- update dt-bindings

Thanks for your time,
Liam

Liam Beguin (3):
clk: add support for the lmk04832
clk: lmk04832: add support for digital delay
dt-bindings: clock: add ti,lmk04832 bindings

 .../bindings/clock/ti,lmk04832.yaml           |  209 +++
 drivers/clk/Kconfig                           |    7 +
 drivers/clk/Makefile                          |    1 +
 drivers/clk/clk-lmk04832.c                    | 1596 +++++++++++++++++
 4 files changed, 1813 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/ti,lmk04832.yaml
 create mode 100644 drivers/clk/clk-lmk04832.c

Range-diff against v4:
1: cb6a8ea514d8 ! 1: 11461912b3c4 clk: add support for the lmk04832

    @@ drivers/clk/clk-lmk04832.c (new)
     +		if (ret) {
     +			dev_err(lmk->dev, "missing reg property in child: %s\n",
     +				child->full_name);
    ++			of_node_put(child);
     +			goto err_disable_oscin;
     +		}
     +
    @@ drivers/clk/clk-lmk04832.c (new)
     +
     +		lmk->clkout[reg].sysref =
     +			of_property_read_bool(child, "ti,clkout-sysref");
    -+	};
    ++	}
     +
     +	lmk->regmap = devm_regmap_init_spi(spi, &regmap_config);
     +	if (IS_ERR(lmk->regmap)) {
2:  8464eac02aab = 2:  01b64b5af4ed clk: lmk04832: add support for digital delay
3:  a2c4e8d53d1c ! 3:  96b514765de0 dt-bindings: clock: add ti,lmk04832 bindings

@@ Documentation/devicetree/bindings/clock/ti,lmk04832.yaml (new)
+ const: 1
+
+ spi-max-frequency:
-+ $ref: /schemas/types.yaml#/definitions/uint32
-+ description:
-+ Maximum SPI clocking speed of the device in Hz.
++ maximum: 5000000
+
+ clocks:
+ items:
@@ Documentation/devicetree/bindings/clock/ti,lmk04832.yaml (new)
+ required:
+ - reg
+
++ additionalProperties: false
++
+required:
+ - compatible
+ - reg

base-commit: f40ddce88593482919761f74910f42f4b84c004b

Signature · 1 line
2.30.1.489.g328c10930387