Skip to content

tools/xenstore: support live update for xenstored

Juergen Gross xen-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest27 patches 0 repliesNew
  2. v1127 patches 10 repliesSuperseded
  3. v1025 patches 8 repliesSuperseded

Changes in v12 from the cover letter

- addressed Andrew's comments (patches 1-5)
- fixed mangled patches 12 and 13

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27tools/libxenevtchn: switch to standard xen coding styletools/libs/evtchn/core.c tools/libs/evtchn/freebsd.c tools/libs/evtchn/linux.c +3 more+131 -540 replies
2/27tools/libxenevtchn: rename open_flags to flagstools/include/xenevtchn.h tools/libs/evtchn/core.c+2 -20 replies
3/27tools/libxenevtchn: check xenevtchn_open() flags for not supported bitstools/libs/evtchn/core.c+9 -10 replies
4/27tools/libxenevtchn: propagate xenevtchn_open() flags parametertools/libs/evtchn/core.c tools/libs/evtchn/freebsd.c tools/libs/evtchn/linux.c +4 more+7 -70 replies
5/27tools/libxenevtchn: add possibility to not close file descriptor on exectools/include/xenevtchn.h tools/libs/evtchn/Makefile tools/libs/evtchn/core.c +4 more+97 -380 replies
6/27tools/xenstore: refactor XS_CONTROL handlingtools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+25 -130 replies
7/27tools/xenstore: add live update command to xenstore-controldocs/misc/xenstore.txt tools/xenstore/Makefile tools/xenstore/xenstore_control.c +1 more+370 -170 replies
8/27tools/xenstore: add basic live-update command parsingtools/xenstore/xenstored_control.c+104 -10 replies
9/27tools/xenstore: introduce live update status blocktools/xenstore/xenstored_control.c+63 -00 replies
10/27tools/xenstore: save new binary for live updatetools/xenstore/xenstored_control.c+40 -10 replies
11/27tools/xenstore: add command line handling for live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c+12 -10 replies
12/27tools/xenstore: add support for delaying execution of a xenstore requesttools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+82 -10 replies
13/27tools/xenstore: add the basic framework for doing the live updatetools/xenstore/xenstored_control.c+67 -20 replies
14/27tools/xenstore: allow live update only with no transaction activetools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.h tools/xenstore/xenstored_transaction.c+33 -20 replies
15/27docs: update the xenstore migration stream documentationdocs/designs/xenstore-migration.md+10 -90 replies
16/27tools/xenstore: add include file for state structure definitionstools/xenstore/include/xenstore_state.h+131 -00 replies
17/27tools/xenstore: dump the xenstore state for live updatetools/xenstore/utils.c tools/xenstore/utils.h tools/xenstore/xenstored_control.c +6 more+512 -60 replies
18/27tools/xenstore: handle CLOEXEC flag for local files and pipestools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h +2 more+31 -30 replies
19/27tools/xenstore: split off domain introduction from do_introduce()tools/xenstore/xenstored_domain.c+55 -400 replies
20/27tools/xenstore: evaluate the live update flag when startingtools/xenstore/xenstored_control.c tools/xenstore/xenstored_control.h tools/xenstore/xenstored_core.c +3 more+51 -290 replies
21/27tools/xenstore: read internal state when doing live upgradetools/xenstore/xenstored_control.c+101 -10 replies
22/27tools/xenstore: add reading global state for live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+12 -00 replies
23/27tools/xenstore: add read connection state for live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h +2 more+162 -130 replies
24/27tools/xenstore: add read node state for live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+96 -110 replies
25/27tools/xenstore: add read watch state for live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_watch.c tools/xenstore/xenstored_watch.h+88 -300 replies
26/27tools/xenstore: handle dying domains in live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_domain.c tools/xenstore/xenstored_domain.h+26 -80 replies
27/27tools/xenstore: activate new binary for live updatetools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h +2 more+75 -10 replies

Reviews trailers per patch

23 of 27 patches have a Reviewed-by or Acked-by.

PatchAndrew CooperWei LiuJulien GrallPaul Durrant
1/27A-b
2/27R-b
3/27R-b
4/27A-b
5/27R-b R-b
6/27R-b R-b
7/27R-b R-b
8/27R-b R-b
9/27R-b R-b
10/27R-b R-b
11/27R-b R-b
12/27
13/27
14/27
15/27R-b
16/27A-b
17/27A-b R-b
18/27A-b
19/27R-b
20/27R-b
21/27A-b R-b
22/27A-b R-b
23/27R-b
24/27A-b R-b
25/27R-b
26/27R-b
27/27

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/27] tools/xenstore: support live update for xenstored

Today Xenstore is not restartable. This means a Xen server needing an update of xenstored has to be rebooted in order to let this update become effective.

This patch series is changing that: The internal state of xenstored (the contents of Xenstore, all connections to various clients like programs or other domains, and watches) is saved in a defined format and a new binary is being activated consuming the old state. All connections are being restored and the new Xenstore binary will continue where the old one stopped.

This patch series has been under (secret) development until V9. It has been posted to xen-devel only from V10 onwards.

There will be a similar series for oxenstored posted.

Xenstore-stubdom is not yet supported, but I'm planning to start working on that soon.

Changes in V12:
- addressed Andrew's comments (patches 1-5)
- fixed mangled patches 12 and 13

Changes in V11:
- dropped patches 1-3 of V10 as already appled
- new patches 1-4 (Andrew Cooper): more libxenevtchn cleanup
- new patch 12 (Edwin Torok): handle timeout of LU completely in xenstored instead of split xenstore-control/xenstored. I've kept the xenstore-control timeout handling for the case of premature LU supporting downstream versions

Changes in V10 (for the members of the security team):
- dropped patch 6 as requested by Andrew

Juergen Gross (26):
tools/libxenevtchn: switch to standard xen coding style tools/libxenevtchn: rename open_flags to flags tools/libxenevtchn: check xenevtchn_open() flags for not supported
bits
tools/libxenevtchn: propagate xenevtchn_open() flags parameter tools/libxenevtchn: add possibility to not close file descriptor on
exec
tools/xenstore: refactor XS_CONTROL handling tools/xenstore: add live update command to xenstore-control tools/xenstore: add basic live-update command parsing tools/xenstore: introduce live update status block tools/xenstore: save new binary for live update tools/xenstore: add command line handling for live update tools/xenstore: add support for delaying execution of a xenstore
request
tools/xenstore: add the basic framework for doing the live update tools/xenstore: allow live update only with no transaction active
docs: update the xenstore migration stream documentation tools/xenstore: add include file for state structure definitions tools/xenstore: dump the xenstore state for live update tools/xenstore: handle CLOEXEC flag for local files and pipes tools/xenstore: split off domain introduction from do_introduce() tools/xenstore: evaluate the live update flag when starting tools/xenstore: read internal state when doing live upgrade tools/xenstore: add reading global state for live update tools/xenstore: add read connection state for live update tools/xenstore: add read node state for live update tools/xenstore: add read watch state for live update tools/xenstore: activate new binary for live update

Julien Grall (1):
tools/xenstore: handle dying domains in live update

 docs/designs/xenstore-migration.md      |  19 +-
 docs/misc/xenstore.txt                  |  21 +
 tools/include/xenevtchn.h               |  52 +-
 tools/libs/evtchn/Makefile              |   2 +-
 tools/libs/evtchn/core.c                |  74 ++-
 tools/libs/evtchn/freebsd.c             |  34 +-
 tools/libs/evtchn/libxenevtchn.map      |   4 +
 tools/libs/evtchn/linux.c               |  12 +-
 tools/libs/evtchn/minios.c              | 104 +++-
 tools/libs/evtchn/netbsd.c              |  24 +-
 tools/libs/evtchn/private.h             |   2 +-
 tools/libs/evtchn/solaris.c             |  14 +-
 tools/xenstore/Makefile                 |   3 +-
 tools/xenstore/include/xenstore_state.h | 131 +++++
 tools/xenstore/utils.c                  |  17 +
 tools/xenstore/utils.h                  |   6 +
 tools/xenstore/xenstore_control.c       | 333 +++++++++++-
 tools/xenstore/xenstored_control.c      | 649 +++++++++++++++++++++++-
 tools/xenstore/xenstored_control.h      |   1 +
 tools/xenstore/xenstored_core.c         | 556 ++++++++++++++++++--
 tools/xenstore/xenstored_core.h         |  59 +++
 tools/xenstore/xenstored_domain.c       | 301 ++++++++---
 tools/xenstore/xenstored_domain.h       |  11 +-
 tools/xenstore/xenstored_posix.c        |  13 +-
 tools/xenstore/xenstored_transaction.c  |   5 +
 tools/xenstore/xenstored_watch.c        | 171 +++++--
 tools/xenstore/xenstored_watch.h        |   5 +
 27 files changed, 2362 insertions(+), 261 deletions(-)
 create mode 100644 tools/xenstore/include/xenstore_state.h
Signature · 1 line
2.26.2