Skip to content

spl: fit: Play nicely with OP-TEE and Linux

Alexandru Gagniuc u-boot 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 0 repliesNew
  2. v38 patches 0 repliesSuperseded
  3. v28 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches0 repliesSuperseded

Changes since v2 from the cover letter

* Fix copmiler error for IMX spl.c

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8spl: fit: Drop 'length' argument to board_spl_fit_post_load()arch/arm/mach-imx/spl.c common/spl/spl_fit.c include/spl.h+8 -71 reply
2/8spl: fit: Factor out FIT parsing and use a context structcommon/spl/spl_fit.c+60 -301 reply
3/8spl: fit: Pass FIT context via a structure pointercommon/spl/spl_fit.c+43 -581 reply
4/8spl: fit: Remove useless loop in spl_fit_get_image_name()common/spl/spl_fit.c+1 -111 reply
5/8spl: fit: Only look up FIT configuration node oncecommon/spl/spl_fit.c+9 -101 reply
6/8image: Do not #if guard board_fit_image_post_process() prototypeinclude/image.h+0 -71 reply
7/8spl: fit: Replace #ifdef blocks with more readable constructscommon/spl/spl_fit.c+24 -291 reply
8/8spl: fit: Load devicetree when a Linux payload is foundcommon/spl/spl_fit.c+15 -31 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchPeng FanSimon Glass
1/8R-b R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/8] spl: fit: Play nicely with OP-TEE and Linux

The purpose of this series is to allow SPL to boot an image with both OP-TEE and Linux.

The "simple" fit code was mostly ready for this, albeit quite unreadable. To be able to make these changes reviewable, some major refactoring had to be done. In fact, of the eight changes, (6) are refactoring patches, and (2) are functional changes.

I wish I could have written this with a negative line count. I have unfortunately failed at that, and this series will be adding 5 lines to u-boot. The takeaway is that the following type FIT can be loaded from SPL directly:

        images {
                optee at 1 {
                        type = "tee";
                        os = "tee";
                        ...
                };
                kernel at 1 {
                        type = "kernel";
                        os = "linux";
			...
                };
                fdt at devicetree.dtb { ... }
                fdt at overlay.dto { ... };
        };

        configurations {
                conf at quickboot {
                        kernel = "optee at 1";
                        fdt = "fdt at stm32mp157c-ev1.dtb", "fdt at overlay.dto";
                        loadables = "kernel at 1";
                };
        };

Changes since v2:
* Fix copmiler error for IMX spl.c

Changes since v2:
* Fixed embarrasing rebase mishap on one of the patches.

Changes since v1:
* Added struct comments (Simon Glass)
* Added comment do describe args of board_spl_fit_post_load() (Simon Glass)
* Fixed predicate of if clause on spl_load_simple_fit() (me)

Alexandru Gagniuc (8):
spl: fit: Drop 'length' argument to board_spl_fit_post_load()
spl: fit: Factor out FIT parsing and use a context struct
spl: fit: Pass FIT context via a structure pointer
spl: fit: Remove useless loop in spl_fit_get_image_name()
spl: fit: Only look up FIT configuration node once
image: Do not #if guard board_fit_image_post_process() prototype
spl: fit: Replace #ifdef blocks with more readable constructs
spl: fit: Load devicetree when a Linux payload is found

 arch/arm/mach-imx/spl.c |   7 +-
 common/spl/spl_fit.c    | 261 +++++++++++++++++++++-------------------
 include/image.h         |   7 --
 include/spl.h           |   4 +-
 4 files changed, 142 insertions(+), 137 deletions(-)
Signature · 1 line
2.26.2