Skip to content

PPC64: Add support for the new prefixed instructions

Gustavo Romero qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 1 replyIn review

Changes in v2 from the cover letter

- Fixes accordingly to Alex Bennée's review:
Removed fixes for BUILD_DIR and quiet-command since they are already upstream.
Reverted all the tests to ppc64le-linux-user as they are not softmmu tests. To run it:

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7target/ppc: Add infrastructure for prefixed instructionstarget/ppc/cpu.h target/ppc/internal.h target/ppc/translate.c +1 more+218 -71 reply
2/7target/ppc: Add support for prefixed load/store instructionstarget/ppc/internal.h target/ppc/translate.c+270 -00 replies
3/7tests/tcg: Add tests for prefixed load/store instructionstests/tcg/ppc64 tests/tcg/ppc64le/Makefile.target tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c+962 -00 replies
4/7target/ppc: Add support for paired vector load/store instructionstarget/ppc/helper.h target/ppc/internal.h target/ppc/mem_helper.c +2 more+145 -00 replies
5/7tests/tcg: Add tests for paired vector load/store instructionstests/tcg/ppc64le/Makefile.target tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c+576 -00 replies
6/7target/ppc: Add support for prefixed load/store FP instructionstarget/ppc/translate/fp-impl.c.inc target/ppc/translate/fp-ops.c.inc+54 -00 replies
7/7tests/tcg: Add tests for prefixed load/store FP instructionstests/tcg/ppc64le/Makefile.target tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c+274 -00 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchGustavo Romero
1/7
2/7
3/7
4/7Sgined-off-by
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] PPC64: Add support for the new prefixed instructions

This series aims to add support for the new prefixed instructions introduced with POWER10 CPUs (ISA v3.1).

v2:

- Fixes accordingly to Alex Bennée's review:
Removed fixes for BUILD_DIR and quiet-command since they are already upstream.
Reverted all the tests to ppc64le-linux-user as they are not softmmu tests. To run it:

  $ ../configure --target-list=ppc64le-linux-user
  $ make -j $(nproc) check-tcg

- Fixes accordingly to David's review:
Clarifications for the opcode lookup table and its namespaces (normal insn, prefixed type 0/1, and prefixed 2/3). Clarification about R macro.
Fixed missing switch 'break' in parse_prefix_subtype and c1_idx break. Fixed duplicated comments.

- Fixed build when target != TARGET_PPC64.

Michael Roth (7):
target/ppc: Add infrastructure for prefixed instructions target/ppc: Add support for prefixed load/store instructions tests/tcg: Add tests for prefixed load/store instructions target/ppc: Add support for paired vector load/store instructions tests/tcg: Add tests for paired vector load/store instructions target/ppc: Add support for prefixed load/store FP instructions tests/tcg: Add tests for prefixed load/store FP instructions

 target/ppc/cpu.h                              |  30 +-
 target/ppc/helper.h                           |   3 +
 target/ppc/internal.h                         |  27 +
 target/ppc/mem_helper.c                       |  61 ++
 target/ppc/translate.c                        | 442 +++++++-
 target/ppc/translate/fp-impl.c.inc            |  48 +
 target/ppc/translate/fp-ops.c.inc             |   6 +
 target/ppc/translate/vsx-impl.c.inc           |  66 ++
 target/ppc/translate_init.c.inc               |  11 +-
 tests/tcg/ppc64                               |   1 +
 tests/tcg/ppc64le/Makefile.target             |  29 +
 .../test-paired-load-store-vsx.c              | 567 +++++++++++
 .../test-prefixed-load-store-fp.c             | 270 +++++
 .../test-prefixed-load-store.c                | 945 ++++++++++++++++++
 14 files changed, 2499 insertions(+), 7 deletions(-)
 create mode 120000 tests/tcg/ppc64
 create mode 100644 tests/tcg/ppc64le/Makefile.target
 create mode 100644 tests/tcg/ppc64le/instruction-tests/test-paired-load-store-vsx.c
 create mode 100644 tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store-fp.c
 create mode 100644 tests/tcg/ppc64le/instruction-tests/test-prefixed-load-store.c
Signature · 1 line
2.17.1