Skip to content

Cleanup includes for no-TCG builds

Paolo Bonzini qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3remove TCG includes from common codeaccel/stubs/tcg-stub.c accel/tcg/cputlb.c accel/tcg/translate-all.c +6 more+5 -92 replies
2/3move icache flush out of tcg.hinclude/exec/flush-icache.h softmmu/physmem.c tcg/aarch64/tcg-target.h +11 more+91 -692 replies
3/3trace: do not include TCG helper tracepoints in no-TCG buildstrace/meson.build+1 -14 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonPhilippe Mathieu-Daudé
1/3R-b R-b
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Cleanup includes for no-TCG builds

Right now, accel/tcg and tcg/$tcg_target are part of the include path for all builds, mostly due to exec/translate-all.h and the flush_icache_range function. But there's also a few useless tcg/tcg.h includes that can simply be removed.

This small series, mostly consisting of code movement and file renames, starts cleaning up this area.

Paolo

Paolo Bonzini (3):
remove TCG includes from common code
move icache flush out of tcg.h
trace: do not include TCG helper tracepoints in no-TCG builds

 accel/stubs/tcg-stub.c                      |  1 -
 accel/tcg/cputlb.c                          |  2 +-
 accel/tcg/translate-all.c                   |  2 +-
 accel/tcg/user-exec.c                       |  2 +-
 cpu.c                                       |  2 +-
 hw/i386/kvmvapic.c                          |  1 -
 include/exec/flush-icache.h                 | 64 +++++++++++++++++++++
 {accel/tcg => include/exec}/translate-all.h |  0
 monitor/misc.c                              |  1 -
 softmmu/physmem.c                           |  4 +-
 tcg/aarch64/tcg-target.h                    |  5 --
 tcg/arm/tcg-target.h                        |  5 --
 tcg/i386/tcg-target.h                       |  4 --
 tcg/mips/tcg-target.h                       | 11 ----
 tcg/ppc/tcg-target.c.inc                    | 22 --------
 tcg/ppc/tcg-target.h                        |  1 -
 tcg/riscv/tcg-target.h                      |  5 --
 tcg/s390/tcg-target.h                       |  4 --
 tcg/sparc/tcg-target.h                      |  8 ---
 tcg/tcg.c                                   |  1 +
 tcg/tci/tcg-target.h                        |  4 --
 trace/meson.build                           |  2 +-
 util/cacheinfo.c                            | 25 +++++++++
 23 files changed, 97 insertions(+), 79 deletions(-)
 create mode 100644 include/exec/flush-icache.h
 rename {accel/tcg => include/exec}/translate-all.h (100%)
Signature · 1 line
2.28.0