x86: Support Key Locker
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest12 patches 11 repliesIn review
- v413 patches 9 repliesSuperseded
- v315 patches 13 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 RFC | 11 patches | 16 replies | Superseded | |
| v1 RFC | 8 patches | 21 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | Documentation/x86: Document Key LockerDocumentation/ Documentation/ | +99 | 1 reply | |
| 2/12 | x86/cpufeature: Enumerate Key Locker featurearch/ arch/ arch/ +1 more | +11 | 0 replies | |
| 3/12 | x86/insn: Add Key Locker instructions to the opcode maparch/ tools/ | +14 | 0 replies | |
| 4/12 | x86/asm: Add a wrapper function for the LOADIWKEY instructionarch/ arch/ | +57 | 0 replies | |
| 5/12 | x86/msr-index: Add MSRs for Key Locker internal wrapping keyarch/ | +6 | 0 replies | |
| 6/12 | x86/keylocker: Define Key Locker CPUID leafarch/ | +7 | 0 replies | |
| 7/12 | x86/cpu/keylocker: Load an internal wrapping key at boot-timearch/ arch/ arch/ +2 more | +95 | 8 replies | |
| 8/12 | x86/PM/keylocker: Restore internal wrapping key on resume from ACPI S3/4arch/ arch/ arch/ | +128 | 0 replies | |
| 8/12 | x86/PM/keylocker: Restore internal wrapping key on resume from ACPI S3/4arch/ arch/ arch/ | +132 | 0 replies | |
| 9/12 | x86/cpu: Add a configuration and command line option for Key LockerDocumentation/ arch/ arch/ | +21 | 0 replies | |
| 10/12 | crypto: x86/aes - Prepare for a new AES implementationarch/ arch/ arch/ +4 more | +309 | 0 replies | |
| 11/12 | crypto: x86/aes-kl - Support AES algorithm using Key Locker instructionsarch/ arch/ arch/ +1 more | +338 | 0 replies | |
| 12/12 | crypto: x86/aes-kl - Support XTS modearch/ arch/ | +553 | 0 replies |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dan Williams | Rafael J. Wysocki | Bagas Sanjaya | Eric Biggers | Randy Dunlap |
|---|---|---|---|---|---|
| Series | R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b A-b A-b A-b R-b R-b R-b R-b R-b R-b R-b R-b R-b A-b A-b R-b R-b R-b R-b R-b R-b R-b A-b A-b R-b R-b R-b R-b R-b R-b R-b R-b R-b A-b A-b | A-b A-b A-b A-b A-b | R-b R-b | R-b R-b | R-b |
| 1/12 | R-b | ||||
| 2/12 | R-b | ||||
| 3/12 | R-b | ||||
| 4/12 | R-b | ||||
| 5/12 | R-b | ||||
| 6/12 | R-b | ||||
| 7/12 | R-b | ||||
| 8/12 | R-b R-b | A-b A-b | |||
| 8/12 | R-b R-b | A-b A-b | |||
| 9/12 | R-b | ||||
| 10/12 | A-b | ||||
| 11/12 | R-b | ||||
| 12/12 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v5 00/12] x86: Support Key Locker
Changes from v4 [1]:
* Drop CBC mode support (PATCH10). (Eric Biggers)
* Update the changelog (PATCH8). (Rafael Wysocki)
A couple of other things outside of these patches are still in progress:
* Support DM-crypt/cryptsetup for Key Locker usage (Andy Lutomirski) [2].
* Understand decryption under-performance (Eric Biggers and Milan Broz) [3][4].
This feature's usage for the threat model can be found in the previous cover letter [1]. This version is based on 5.16.
Thanks,
Chang
[1] V4: https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/lkml/[email protected]/
[4] https://lore.kernel.org/lkml/[email protected]/
Chang S. Bae (12):
Documentation/x86: Document Key Locker
x86/cpufeature: Enumerate Key Locker feature
x86/insn: Add Key Locker instructions to the opcode map x86/asm: Add a wrapper function for the LOADIWKEY instruction x86/msr-index: Add MSRs for Key Locker internal wrapping key x86/keylocker: Define Key Locker CPUID leaf x86/cpu/keylocker: Load an internal wrapping key at boot-time x86/PM/keylocker: Restore internal wrapping key on resume from ACPI
S3/4
x86/cpu: Add a configuration and command line option for Key Locker
crypto: x86/aes - Prepare for a new AES implementation
crypto: x86/aes-kl - Support AES algorithm using Key Locker
instructions
crypto: x86/aes-kl - Support XTS mode
.../admin-guide/kernel-parameters.txt | 2 + Documentation/x86/index.rst | 1 + Documentation/x86/keylocker.rst | 98 +++ arch/x86/Kconfig | 3 + arch/x86/crypto/Makefile | 5 +- arch/x86/crypto/aes-intel_asm.S | 26 + arch/x86/crypto/aes-intel_glue.c | 125 ++++ arch/x86/crypto/aes-intel_glue.h | 48 ++ arch/x86/crypto/aeskl-intel_asm.S | 633 ++++++++++++++++++ arch/x86/crypto/aeskl-intel_glue.c | 216 ++++++ arch/x86/crypto/aesni-intel_asm.S | 58 +- arch/x86/crypto/aesni-intel_glue.c | 239 ++----- arch/x86/crypto/aesni-intel_glue.h | 17 + arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/keylocker.h | 45 ++ arch/x86/include/asm/msr-index.h | 6 + arch/x86/include/asm/special_insns.h | 32 + arch/x86/include/uapi/asm/processor-flags.h | 2 + arch/x86/kernel/Makefile | 1 + arch/x86/kernel/cpu/common.c | 21 +- arch/x86/kernel/cpu/cpuid-deps.c | 1 + arch/x86/kernel/keylocker.c | 199 ++++++ arch/x86/kernel/smpboot.c | 2 + arch/x86/lib/x86-opcode-map.txt | 11 +- arch/x86/power/cpu.c | 2 + crypto/Kconfig | 36 + tools/arch/x86/lib/x86-opcode-map.txt | 11 +- 28 files changed, 1633 insertions(+), 216 deletions(-) create mode 100644 Documentation/x86/keylocker.rst create mode 100644 arch/x86/crypto/aes-intel_asm.S create mode 100644 arch/x86/crypto/aes-intel_glue.c create mode 100644 arch/x86/crypto/aes-intel_glue.h create mode 100644 arch/x86/crypto/aeskl-intel_asm.S create mode 100644 arch/x86/crypto/aeskl-intel_glue.c create mode 100644 arch/x86/crypto/aesni-intel_glue.h create mode 100644 arch/x86/include/asm/keylocker.h create mode 100644 arch/x86/kernel/keylocker.c
base-commit: df0cc57e057f18e44dac8e6c18aba47ab53202f9 --
2.17.1