Skip to content

sched/fair: Burstable CFS bandwidth controller

Huaixin Chang lkml 6 versions – Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 12 repliesApplied
  2. v53 patches 17 repliesSuperseded
  3. v44 patches 16 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches13 repliesSuperseded
v20 of 4 patches0 repliesSuperseded
v14 patches5 repliesSuperseded

Changes in v6 from the cover letter

- Separate burst config to cpu.max.burst.
- Rewrite commit log and document for burst feature.
- Remove global sysfsctl to disable burst feature.
- Some code mofication.
- Rebase upon v5.13-rc6.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/3sched/fair: Introduce the burstable CFS controllerkernel/sched/core.c kernel/sched/fair.c kernel/sched/sched.h+72 -107 replies
2/3sched/fair: Add cfs bandwidth burst statisticskernel/sched/core.c kernel/sched/fair.c kernel/sched/sched.h+24 -33 replies
3/3sched/fair: Add document for burstable CFS bandwidthDocumentation/admin-guide/cgroup-v2.rst Documentation/scheduler/sched-bwc.rst+89 -101 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTejun HeoBen Segall
SeriesA-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] sched/fair: Burstable CFS bandwidth controller

Changelog:
v6:
- Separate burst config to cpu.max.burst.
- Rewrite commit log and document for burst feature.
- Remove global sysfsctl to disable burst feature.
- Some code mofication.
- Rebase upon v5.13-rc6.

v5:
- Rearrange into 3 patches, one less than the previous version.
- The interference to other groups are valued.
- Put a limit on burst, so that code is further simplified.
- Rebase upon v5.13-rc3.
Link:
https://lore.kernel.org/lkml/[email protected]/

v4:
- Adjust assignments in tg_set_cfs_bandwidth(), saving unnecessary assignemnts when quota == RUNTIME_INF.
- Getting rid of sysctl_sched_cfs_bw_burst_onset_percent, as there seems no justification for both controlling start bandwidth and a percent way.
- Comment improvement in sched_cfs_period_timer() shifts on explaining why max_overrun shifting to 0 is a problem.
- Rename previous_runtime to runtime_at_period_start.
- Add cgroup2 interface and documentation.
- Getting rid of exposing current_bw as there are not enough justification and the updating problem.
- Add justification on cpu.stat change in the changelog.
- Rebase upon v5.12-rc3.
- Correct SoB chain.
- Several indentation fixes.
- Adjust quota in schbench test from 700000 to 600000.
Link:
https://lore.kernel.org/lkml/[email protected]/

v3:
- Fix another issue reported by test robot.
- Update docs as Randy Dunlap suggested.
Link:
https://lore.kernel.org/lkml/[email protected]/

v2:
- Fix an issue reported by test robot.
- Rewriting docs. Appreciate any further suggestions or help. Link:
https://lore.kernel.org/lkml/[email protected]/

v1 Link:
https://lore.kernel.org/lkml/[email protected]/

Previously, Cong Wang and Konstantin Khlebnikov proposed similar feature:
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/157476581065.5793.4518979877345136813.stgit@buzz/

This time we present more latency statistics and handle overflow while accumulating.

Huaixin Chang (3):
sched/fair: Introduce the burstable CFS controller sched/fair: Add cfs bandwidth burst statistics sched/fair: Add document for burstable CFS bandwidth

 Documentation/admin-guide/cgroup-v2.rst | 17 +++---
 Documentation/scheduler/sched-bwc.rst   | 76 ++++++++++++++++++++++----
 include/linux/sched/sysctl.h            |  1 +
 kernel/sched/core.c                     | 96 ++++++++++++++++++++++++++-------
 kernel/sched/fair.c                     | 32 ++++++++++-
 kernel/sched/sched.h                    |  4 ++
 kernel/sysctl.c                         |  9 ++++
 7 files changed, 200 insertions(+), 35 deletions(-)
Signature · 1 line
2.14.4.44.g2045bb6