Skip to content

Various multipath-tools patches

[email protected] dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7libmultipath: move logq_lock handling to log.clibmultipath/log.c libmultipath/log_pthread.c+32 -111 reply
2/7libmultipath: protect logarea with logq_locklibmultipath/log.c libmultipath/log.h+23 -103 replies
3/7libmultipath: prevent DSO unloading with astray checker threadslibmultipath/checkers.c libmultipath/checkers.h libmultipath/checkers/tur.c +1 more+97 -131 reply
4/7libmultipath: force map reload if udev incompletelibmultipath/configure.c+29 -164 replies
5/7multipath-tools: avoid access to /etc/localtimelibmultipath/debug.c libmultipath/devmapper.c libmultipath/log.c +1 more+14 -161 reply
6/7multipath-tools: make sure plugin DSOs use symbol versionsMakefile Makefile.inc libmpathpersist/Makefile +3 more+15 -141 reply
7/7libmultipath.version: add missing symbollibmultipath/libmultipath.version+5 -01 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchBenjamin Marzinski
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [dm-devel] [PATCH 0/7] Various multipath-tools patches

From: Martin Wilck <[email protected]>

Hi Christophe, hi Ben,

here are a few patches that have accumulated while I hadn't fixed my previous series "libmultipath: improve cleanup on exit"

The first two are actually related to the log_thread work I did in that series, but they're additional fixes on top and I didn't want to delay that series further by adding additional, possibly controversial stuff.

No 3 is the 2nd attempt to allow unloading of checker DSOs, hopefully fixing the issues Ben saw with the first one.

No 4 is probably the most important one. It fixes the same issue that 2b25a9e and cb10d38 targeted, but the previous fixes still didn't cover all corner cases. This one does, I believe.

No 5 tackles a new failure mode we recently discovered - multipathd may block trying to access the root FS while this is in queuing mode. This patch removes one very frequent access pattern.
This is work in progress; there are other file system accesses from multipathd which might block.

Obviously the wwids, prkeys, and bindings files' contents need to be cached. I haven't made up my mind how to handle writing changes back. Would be sufficient to write back when multipathd exits, possibly with an external program (e.g. "ExecStartPost")? Or should we try to write back directly at runtime, using separate threads to avoid blocking of the main thread? "reconfigure" is another issue, but perhaps less problematic - if the root FS is blocked, users couldn't edit /etc/multipath.conf anyway. One might consider moving everything to tmpfs or even running in a tmpfs-backed chroot, but it still would beg the question how to make certain changes permanent, like wwids and bindings.

6 and 7 fix oversights in my library versioning series. The plugins didn't have symbol versions set on the symbols they referenced, making the versioning at least partly non-functional.

Regards
Martin

Martin Wilck (7):
libmultipath: move logq_lock handling to log.c
libmultipath: protect logarea with logq_lock
libmultipath: prevent DSO unloading with astray checker threads
libmultipath: force map reload if udev incomplete
multipath-tools: avoid access to /etc/localtime
multipath-tools: make sure plugin DSOs use symbol versions libmultipath.version: add missing symbol

 Makefile                           |  1 +
 Makefile.inc                       |  2 +-
 libmpathpersist/Makefile           |  8 ++--
 libmultipath/checkers.c            | 68 +++++++++++++++++++++++++++---
 libmultipath/checkers.h            | 25 +++++++++++
 libmultipath/checkers/Makefile     |  7 ++-
 libmultipath/checkers/tur.c        | 12 +++---
 libmultipath/configure.c           | 45 +++++++++++++-------
 libmultipath/debug.c               | 14 +++---
 libmultipath/devmapper.c           | 12 +++---
 libmultipath/foreign/Makefile      |  4 +-
 libmultipath/libmultipath.version  | 10 +++++
 libmultipath/log.c                 | 59 ++++++++++++++++++++++----
 libmultipath/log.h                 |  1 -
 libmultipath/log_pthread.c         |  9 ----
 libmultipath/prioritizers/Makefile |  7 ++-
 multipathd/main.c                  |  3 --
 17 files changed, 211 insertions(+), 76 deletions(-)
Signature · 7 lines
2.29.0


--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel