Skip to content

Fix _send_qemu_cmd with bash 5.1

Max Reitz qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iotests/102: Pass $QEMU_HANDLE to _send_qemu_cmdtests/qemu-iotests/102 tests/qemu-iotests/102.out+2 -20 replies
2/2iotests: Fix _send_qemu_cmd with bash 5.1tests/qemu-iotests/085.out tests/qemu-iotests/094.out tests/qemu-iotests/095.out +21 more+728 -1990 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKevin Wolf
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1

Hi,

See patch 2 for what’s changed in bash 5.1 that makes this series necessary, and what we need to do. (tl;dr: Bash presumably fixed a bug for array slices, and that now breaks nearly all iotests that use _send_qemu_cmd – but we don’t even need an array slice there.)

Patch 1 fixes a bug in 102 in how it calls _send_qemu_cmd. (This becomes really visible with the change in patch 2.)

Comparing patch 2 to v1 (“iotests: Quote $cmd in _send_qemu_cmd”), the reference output diffs haven’t changed, only the common.qemu hunk is different.

Max Reitz (2):
iotests/102: Pass $QEMU_HANDLE to _send_qemu_cmd
iotests: Fix _send_qemu_cmd with bash 5.1

 tests/qemu-iotests/085.out     | 167 ++++++++++++++++++++++++++++-----
 tests/qemu-iotests/094.out     |  10 +-
 tests/qemu-iotests/095.out     |   4 +-
 tests/qemu-iotests/102         |   2 +-
 tests/qemu-iotests/102.out     |   2 +-
 tests/qemu-iotests/109.out     |  88 ++++++++++++-----
 tests/qemu-iotests/117.out     |  13 ++-
 tests/qemu-iotests/127.out     |  12 ++-
 tests/qemu-iotests/140.out     |  10 +-
 tests/qemu-iotests/141.out     | 128 +++++++++++++++++++------
 tests/qemu-iotests/143.out     |   4 +-
 tests/qemu-iotests/144.out     |  28 +++++-
 tests/qemu-iotests/153.out     |  18 ++--
 tests/qemu-iotests/156.out     |  39 ++++++--
 tests/qemu-iotests/161.out     |  18 +++-
 tests/qemu-iotests/173.out     |  25 ++++-
 tests/qemu-iotests/182.out     |  42 +++++++--
 tests/qemu-iotests/183.out     |  19 +++-
 tests/qemu-iotests/185.out     |  45 +++++++--
 tests/qemu-iotests/191.out     |  12 ++-
 tests/qemu-iotests/223.out     |  92 ++++++++++++------
 tests/qemu-iotests/229.out     |  13 ++-
 tests/qemu-iotests/249.out     |  16 +++-
 tests/qemu-iotests/308.out     | 103 +++++++++++++++++---
 tests/qemu-iotests/312.out     |  10 +-
 tests/qemu-iotests/common.qemu |  11 +--
 26 files changed, 730 insertions(+), 201 deletions(-)
Signature · 1 line
2.29.2