Skip to content

console: remove #ifdef CONFIG when it is possible

Patrick Delaunay u-boot 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v24 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- update commit message with new function name console_has_tstc

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4console: remove #ifdef CONFIG when it is possiblecommon/console.c+64 -942 replies
2/4console: add function console_devices_setcommon/console.c+13 -71 reply
3/4console: remove #ifdef CONFIG_CONSOLE_RECORDcommon/console.c+73 -222 replies
3/4console: remove #ifdef CONFIG_CONSOLE_RECORDcommon/console.c index+0 -00 replies
4/4console: add console_has_tstc helper function for CONSOLE_MUXcommon/console.c+25 -122 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSimon Glass
1/4R-b
2/4R-b
3/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] console: remove #ifdef CONFIG when it is possible

Hi,

It is the V3 of serie [1] after Simon Glass comments.

Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible

This patchset can applied on master branch after the serie [2] (for the new order of test in function putc() and puts()
done in "console: allow to record console output before ready"
)

For information:

I try to remove the sandox code in [3] (with the associated tests #ifdef CONFIG_SANDBOX) but it wasn't a correct idea.

I will pushed a separate serie to remove the remaining #ifdef CONFIG_VIDCONSOLE_AS_LCD [4]

[1] http://patchwork.ozlabs.org/project/uboot/list/?series=218309

[2] http://patchwork.ozlabs.org/project/uboot/list/?series=217079
"log: don't build the trace buffer when log is not ready"

[3] http://patchwork.ozlabs.org/project/uboot/patch/20201127114927.2.Ida70f4fb1524187703e9240d63e436f8ae5adaab at changeid/ "[2/2] console: sandbox: remove unnecessary sandbox code"

[4] http://patchwork.ozlabs.org/project/uboot/list/?series=218307
"video: remove VIDCONSOLE_AS_LCD and VIDCONSOLE_AS_NAME"

Changes in v3:
- update commit message with new function name console_has_tstc

Changes in v2:
- update also #ifdef CONFIG_SANDBOX after Simon Glass remark (code can't be removed to avoid to rely sandbox on debug uart)
- move the tests on gd->flags & GD_FLG_RECORD in helper functions
- remove test on IS_ENABLED(CONFIG_CONSOLE_RECORD) before to call helper functions
- add comment for tstcdev variable
- rename console_tstc_check to console_has_tstc

Patrick Delaunay (4):
console: remove #ifdef CONFIG when it is possible
console: add function console_devices_set
console: remove #ifdef CONFIG_CONSOLE_RECORD
console: add console_has_tstc helper function for CONSOLE_MUX

 common/console.c | 310 ++++++++++++++++++++++++++---------------------
 1 file changed, 175 insertions(+), 135 deletions(-)
Signature · 1 line
2.17.1