Skip to content

hw/block/nvme: misc cmb/pmr patches

Klaus Jensen qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8hw/block/nvme: indicate CMB support through controller capabilities registerhw/block/nvme.c include/block/nvme.h+8 -30 replies
2/8hw/block/nvme: move msix table and pba to BAR 0hw/block/nvme.c hw/block/nvme.h+23 -20 replies
3/8hw/block/nvme: allow cmb and pmr to coexisthw/block/nvme.c+8 -90 replies
4/8hw/block/nvme: fix controller reset/shutdown logichw/block/nvme.c+24 -130 replies
5/8hw/block/nvme: rename CAP_PMR_{SHIFT, MASK} to CAP_PMRS_{SHIFT, MASK}include/block/nvme.h+4 -40 replies
6/8hw/block/nvme: remove redundant zeroing of PMR registershw/block/nvme.c+0 -350 replies
7/8hw/block/nvme: disable PMR at boot uphw/block/nvme.c+12 -20 replies
8/8hw/block/nvme: add PMR RDS/WDS supporthw/block/nvme.c hw/block/nvme.h include/block/nvme.h+87 -30 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchMaxim Levitsky
1/8R-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] hw/block/nvme: misc cmb/pmr patches

From: Klaus Jensen <[email protected]>

This is a resend of "hw/block/nvme: allow cmb and pmr to coexist" with some more PMR work added (PMR RDS/WDS support).

This includes a resurrection of Andrzej's series[1] from back July.

Andrzej's main patch basically moved the the CMB from BAR 2 into an offset in BAR 4 (located after the MSI-X table and PBA). Having an offset on the CMB causes a bunch of calculations related to address mapping to change.

So, since I couldn't get the patch to apply cleanly I took a stab at implementing the suggestion I originally came up with: simply move the MSI-X table and PBA from BAR 4 into BAR 0 (up-aligned to a 4 KiB boundary, after the main NVMe controller registers). This way we can keep the CMB at offset zero in its own BAR and free up BAR 4 for use by PMR. This makes the patch simpler and does not impact any of the existing address mapping code.

Andrzej, I would prefer an Ack from you, since I pretty much voided your main patch.

[1]: https://lore.kernel.org/qemu-devel/[email protected]/

CC Andrzej Jakowski <[email protected]>

Andrzej Jakowski (1):
hw/block/nvme: indicate CMB support through controller capabilities
register

Klaus Jensen (6):
hw/block/nvme: move msix table and pba to BAR 0 hw/block/nvme: allow cmb and pmr to coexist hw/block/nvme: fix controller reset/shutdown logic hw/block/nvme: rename CAP_PMR_{SHIFT,MASK} to CAP_PMRS_{SHIFT,MASK} hw/block/nvme: remove redundant zeroing of PMR registers hw/block/nvme: disable PMR at boot up

Naveen Nagar (1):
hw/block/nvme: add PMR RDS/WDS support

 hw/block/nvme.h      |   2 +
 include/block/nvme.h |  15 ++-
 hw/block/nvme.c      | 216 ++++++++++++++++++++++++++++++-------------
 3 files changed, 164 insertions(+), 69 deletions(-)
Signature · 1 line
2.29.2