Skip to content

Drop support for QAPIGen without a file name

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11qapi/commands: assert arg_type is not Nonescripts/qapi/commands.py+6 -30 replies
2/11qapi/events: fix visit_event typingscripts/qapi/events.py+7 -50 replies
3/11qapi/main: handle theoretical None-return from re.match()scripts/qapi/main.py+2 -00 replies
4/11qapi/gen: assert that _start_if is not None in _wrap_ifcondscripts/qapi/gen.py+1 -10 replies
5/11qapi/gen: use './builtin' for the built-in module namescripts/qapi/gen.py+14 -140 replies
6/11qapi/gen: write _genc/_genh access shimsscripts/qapi/gen.py+13 -50 replies
7/11qapi/gen: Replace ._begin_system_module()scripts/qapi/gen.py scripts/qapi/types.py scripts/qapi/visit.py+4 -40 replies
8/11qapi/gen: Expose a single module name spacescripts/qapi/commands.py scripts/qapi/events.py scripts/qapi/gen.py+7 -130 replies
9/11qapi/gen: Support for switching to another module temporarilyscripts/qapi/gen.py+8 -01 reply
10/11qapi/commands: Simplify command registry generationscripts/qapi/commands.py+22 -271 reply
11/11qapi/gen: Drop support for QAPIGen without a file namescripts/qapi/gen.py+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] Drop support for QAPIGen without a file name

John Snow posted

[PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str

QAPIGenC and QAPIGenH in particular depend on fname being defined, but we have a usage of QAPIGenCCode that isn't intended to be associated with a particular file.

No problem, move the write method down to the class that actually needs it, and keep QAPIGenCCode more abstract.

---
scripts/qapi/commands.py | 2 +-
scripts/qapi/gen.py | 54 ++++++++++++++++++++--------------------
2 files changed, 28 insertions(+), 28 deletions(-)

There is just one user of QAPIGen without a file name, and it's awkward. Let's get rid of it.

Since my work to get rid of it depends on parts of John's series, and I'm pressed for time, I include the parts I need in my series. John, feel free to pick this into your complete series.

John Snow (6):
qapi/commands: assert arg_type is not None qapi/events: fix visit_event typing
qapi/main: handle theoretical None-return from re.match() qapi/gen: assert that _start_if is not None in _wrap_ifcond qapi/gen: use './builtin' for the built-in module name qapi/gen: write _genc/_genh access shims

Markus Armbruster (5):
qapi/gen: Replace ._begin_system_module()
qapi/gen: Expose a single module name space qapi/gen: Support for switching to another module temporarily qapi/commands: Simplify command registry generation qapi/gen: Drop support for QAPIGen without a file name

 scripts/qapi/commands.py | 60 ++++++++++++++++-----------------
 scripts/qapi/events.py   | 14 ++++----
 scripts/qapi/gen.py      | 72 +++++++++++++++++++++++-----------------
 scripts/qapi/main.py     |  2 ++
 scripts/qapi/types.py    |  2 +-
 scripts/qapi/visit.py    |  2 +-
 6 files changed, 82 insertions(+), 70 deletions(-)
Signature · 1 line
2.26.2