Drop support for QAPIGen without a file name
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | qapi/commands: assert arg_type is not Nonescripts/ | +6 | 0 replies | |
| 2/11 | qapi/events: fix visit_event typingscripts/ | +7 | 0 replies | |
| 3/11 | qapi/main: handle theoretical None-return from re.match()scripts/ | +2 | 0 replies | |
| 4/11 | qapi/gen: assert that _start_if is not None in _wrap_ifcondscripts/ | +1 | 0 replies | |
| 5/11 | qapi/gen: use './builtin' for the built-in module namescripts/ | +14 | 0 replies | |
| 6/11 | qapi/gen: write _genc/_genh access shimsscripts/ | +13 | 0 replies | |
| 7/11 | qapi/gen: Replace ._begin_system_module()scripts/ scripts/ scripts/ | +4 | 0 replies | |
| 8/11 | qapi/gen: Expose a single module name spacescripts/ scripts/ scripts/ | +7 | 0 replies | |
| 9/11 | qapi/gen: Support for switching to another module temporarilyscripts/ | +8 | 1 reply | |
| 10/11 | qapi/commands: Simplify command registry generationscripts/ | +22 | 1 reply | |
| 11/11 | qapi/gen: Drop support for QAPIGen without a file namescripts/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/11] Drop support for QAPIGen without a file name
John Snow posted
[PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str
QAPIGenC and QAPIGenH in particular depend on fname being defined, but we have a usage of QAPIGenCCode that isn't intended to be associated with a particular file.
No problem, move the write method down to the class that actually needs it, and keep QAPIGenCCode more abstract.
---
scripts/qapi/commands.py | 2 +-
scripts/qapi/gen.py | 54 ++++++++++++++++++++--------------------
2 files changed, 28 insertions(+), 28 deletions(-)
There is just one user of QAPIGen without a file name, and it's awkward. Let's get rid of it.
Since my work to get rid of it depends on parts of John's series, and I'm pressed for time, I include the parts I need in my series. John, feel free to pick this into your complete series.
John Snow (6):
qapi/commands: assert arg_type is not None qapi/events: fix visit_event typing
qapi/main: handle theoretical None-return from re.match() qapi/gen: assert that _start_if is not None in _wrap_ifcond qapi/gen: use './builtin' for the built-in module name qapi/gen: write _genc/_genh access shims
Markus Armbruster (5):
qapi/gen: Replace ._begin_system_module()
qapi/gen: Expose a single module name space qapi/gen: Support for switching to another module temporarily qapi/commands: Simplify command registry generation qapi/gen: Drop support for QAPIGen without a file name
scripts/qapi/commands.py | 60 ++++++++++++++++----------------- scripts/qapi/events.py | 14 ++++---- scripts/qapi/gen.py | 72 +++++++++++++++++++++++----------------- scripts/qapi/main.py | 2 ++ scripts/qapi/types.py | 2 +- scripts/qapi/visit.py | 2 +- 6 files changed, 82 insertions(+), 70 deletions(-)
Signature · 1 line
2.26.2