Skip to content

ibmvfc: MQ preparatory locking work

Tyrel Datwyler linux-scsi linuxppc-dev lkml 2 versions – Applied

Status from this message: Applied to 5.12/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesApplied
  2. v15 patches 0 repliesSuperseded

Changes in v2 from the cover letter

* Patch 4: Made ibmvfc_locked_done() static fixing a no-prototype warning

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5ibmvfc: define generic queue structure for CRQsdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+107 -620 replies
2/5ibmvfc: make command event pool queue specificdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+55 -500 replies
3/5ibmvfc: define per-queue state/list locksdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+80 -200 replies
4/5ibmvfc: complete commands outside the host/queue lockdrivers/scsi/ibmvscsi/ibmvfc.c drivers/scsi/ibmvscsi/ibmvfc.h+47 -140 replies
5/5ibmvfc: relax locking around ibmvfc_queuecommanddrivers/scsi/ibmvscsi/ibmvfc.c+4 -80 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchBrian King
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] ibmvfc: MQ preparatory locking work

The ibmvfc driver in its current form relies heavily on the host_lock. This patchset introduces a genric queue with its own queue lock and sent/free event list locks. This generic queue allows the driver to decouple the primary queue and future subordinate queues from the host lock reducing lock contention while also relaxing locking for submissions and completions to simply the list lock of the queue in question.

changes in v2:
* Patch 4: Made ibmvfc_locked_done() static fixing a no-prototype warning

Tyrel Datwyler (5):
ibmvfc: define generic queue structure for CRQs
ibmvfc: make command event pool queue specific
ibmvfc: define per-queue state/list locks
ibmvfc: complete commands outside the host/queue lock
ibmvfc: relax locking around ibmvfc_queuecommand

 drivers/scsi/ibmvscsi/ibmvfc.c | 379 ++++++++++++++++++++++-----------
 drivers/scsi/ibmvscsi/ibmvfc.h |  54 +++--
 2 files changed, 286 insertions(+), 147 deletions(-)
Signature · 1 line
2.27.0