Skip to content

powerpc: Fix W=1 compile errors

Cédric Le Goater linuxppc-dev 2 versions – Applied

Status from this message: Applied to powerpc/next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest23 patches 1 replyApplied
  2. v123 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- improved commit logs
- reworked some changes to reduce the number of lines.
- fixed misuse of asm/asm-prototypes.h for soft_nmi_interrupt()

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/23powerpc/mm: Include __find_linux_pte() prototypearch/powerpc/mm/pgtable.c+1 -00 replies
2/23powerpc/pseries/ras: Remove unused variable 'status'arch/powerpc/platforms/pseries/ras.c+4 -90 replies
3/23powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() staticarch/powerpc/platforms/pseries/eeh_pseries.c+1 -10 replies
4/23powerpc/pseries/ras: Make init_ras_hotplug_IRQ() staticarch/powerpc/platforms/pseries/ras.c+1 -10 replies
5/23powerpc/pmem: Include pmem prototypesarch/powerpc/lib/pmem.c+1 -00 replies
6/23powerpc/setup_64: Make some routines staticarch/powerpc/kernel/setup_64.c+4 -30 replies
7/23powerpc/mce: Include prototypesarch/powerpc/kernel/mce.c+1 -00 replies
8/23powerpc/smp: Include tick_broadcast() prototypearch/powerpc/kernel/smp.c+1 -00 replies
9/23powerpc/smp: Make debugger_ipi_callback() staticarch/powerpc/kernel/smp.c+1 -10 replies
10/23powerpc/optprobes: Remove unused routine patch_imm32_load_insns()arch/powerpc/kernel/optprobes.c+0 -190 replies
11/23powerpc/optprobes: Make patch_imm64_load_insns() staticarch/powerpc/kernel/optprobes.c+1 -10 replies
12/23powerpc/mm: Declare some prototypesarch/powerpc/include/asm/book3s/64/mmu-hash.h+2 -00 replies
13/23powerpc/mm: Move hpte_insert_repeating() prototypearch/powerpc/include/asm/book3s/64/mmu-hash.h arch/powerpc/mm/book3s64/hash_hugetlbpage.c+2 -40 replies
14/23powerpc/mm: Declare preload_new_slb_context() prototypearch/powerpc/include/asm/book3s/64/mmu-hash.h+1 -00 replies
15/23powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() staticarch/powerpc/mm/hugetlbpage.c+1 -10 replies
16/23powerpc/mm: Declare arch_report_meminfo() prototype.arch/powerpc/include/asm/pgtable.h+3 -00 replies
17/23powerpc/watchdog: Declare soft_nmi_interrupt() prototypearch/powerpc/include/asm/nmi.h arch/powerpc/kernel/watchdog.c+2 -00 replies
18/23KVM: PPC: Make the VMX instruction emulation routines staticarch/powerpc/kvm/powerpc.c+4 -40 replies
19/23KVM: PPC: Book3S HV: Include prototypesarch/powerpc/kvm/book3s_64_mmu_hv.c+1 -00 replies
20/23KVM: PPC: Book3S HV: Declare some prototypesarch/powerpc/include/asm/kvm_book3s.h+7 -00 replies
21/23powerpc/pseries: Make IOV setup routines staticarch/powerpc/platforms/pseries/setup.c+4 -40 replies
22/23powerpc/pcidn: Make IOV setup routines staticarch/powerpc/platforms/pseries/pci.c+7 -80 replies
23/23powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() staticarch/powerpc/platforms/pseries/eeh_pseries.c+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/23] powerpc: Fix W=1 compile errors

Hello,

Here is an assorted collection of fixes for W=1.

After this series, only a few errors are left, some missing declarations in arch/powerpc/kernel/sys_ppc32.c, panic_smp_self_stop() declaration and a few of these which I don't know how to fix :

./arch/powerpc/xmon/xmon.c: In function ‘xmon_print_symbol’:
./arch/powerpc/xmon/xmon.c:3656:14: error: variable ‘name’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]

   3656 |  const char *name = NULL;
        |              ^~~~

Cheers,

C.

Changes in v2 :

- improved commit logs
- reworked some changes to reduce the number of lines.
- fixed misuse of asm/asm-prototypes.h for soft_nmi_interrupt()

Cédric Le Goater (23):
powerpc/mm: Include __find_linux_pte() prototype powerpc/pseries/ras: Remove unused variable 'status' powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static powerpc/pmem: Include pmem prototypes powerpc/setup_64: Make some routines static powerpc/mce: Include prototypes
powerpc/smp: Include tick_broadcast() prototype powerpc/smp: Make debugger_ipi_callback() static powerpc/optprobes: Remove unused routine patch_imm32_load_insns() powerpc/optprobes: Make patch_imm64_load_insns() static powerpc/mm: Declare some prototypes
powerpc/mm: Move hpte_insert_repeating() prototype powerpc/mm: Declare preload_new_slb_context() prototype powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static powerpc/mm: Declare arch_report_meminfo() prototype. powerpc/watchdog: Declare soft_nmi_interrupt() prototype
KVM: PPC: Make the VMX instruction emulation routines static
KVM: PPC: Book3S HV: Include prototypes
KVM: PPC: Book3S HV: Declare some prototypes powerpc/pseries: Make IOV setup routines static powerpc/pcidn: Make IOV setup routines static powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static

 arch/powerpc/include/asm/book3s/64/mmu-hash.h |  5 +++++
 arch/powerpc/include/asm/kvm_book3s.h         |  7 +++++++
 arch/powerpc/include/asm/nmi.h                |  1 +
 arch/powerpc/include/asm/pgtable.h            |  3 +++
 arch/powerpc/kernel/mce.c                     |  1 +
 arch/powerpc/kernel/optprobes.c               | 21 +------------------
 arch/powerpc/kernel/setup_64.c                |  7 ++++---
 arch/powerpc/kernel/smp.c                     |  3 ++-
 arch/powerpc/kernel/watchdog.c                |  1 +
 arch/powerpc/kvm/book3s_64_mmu_hv.c           |  1 +
 arch/powerpc/kvm/powerpc.c                    |  8 +++----
 arch/powerpc/lib/pmem.c                       |  1 +
 arch/powerpc/mm/book3s64/hash_hugetlbpage.c   |  4 ----
 arch/powerpc/mm/hugetlbpage.c                 |  2 +-
 arch/powerpc/mm/pgtable.c                     |  1 +
 arch/powerpc/platforms/pseries/eeh_pseries.c  |  5 ++---
 arch/powerpc/platforms/pseries/pci.c          | 15 +++++++------
 arch/powerpc/platforms/pseries/ras.c          | 15 +++++--------
 arch/powerpc/platforms/pseries/setup.c        |  8 +++----
 19 files changed, 51 insertions(+), 58 deletions(-)
Signature · 1 line
2.26.2