Skip to content

replace smp barriers in virtio with C11 atomic

Joyce Kong dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net/virtio: remove unnecessary rmb barrierdrivers/net/virtio/virtio_ethdev.c+3 -31 reply
2/4net/virtio: replace smp barrier with IO barrierdrivers/net/virtio/virtqueue.h+13 -141 reply
3/4net/virtio: replace full barrier with relaxed barrier for Arm platformdrivers/net/virtio/virtio_ethdev.c+2 -21 reply
4/4net/virtio: replace full barrier with thread fencedrivers/net/virtio/virtqueue.h+4 -41 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRuifeng WangMaxime Coquelin
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH v1 0/4] replace smp barriers in virtio with C11 atomic

This patchset is to replace rte smp barriers in virtio with C11 atomic built-ins.

The rte_smp_*mb APIs provide full barrier functionality. However, many use cases do not require full barriers. To support such use cases, DPDK will adopt C11 barrier semantics and provide wrappers using C11 atomic built-ins.[1]

With this patch set, under 0.001% acceptable loss with 2 cores on vhost side and 1 core on virtio side, PVP case(vhost-user + virtio-user) has 6.7% perf uplift for the split in_order path on ThunderX2 platform.

[1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst

Joyce Kong (4):
net/virtio: remove unnecessary rmb barrier
net/virtio: replace smp barrier with IO barrier net/virtio: replace full barrier with relaxed barrier for Arm platform net/virtio: replace full barrier with thread fence

 drivers/net/virtio/virtio_ethdev.c | 10 ++++-----
 drivers/net/virtio/virtqueue.h     | 35 +++++++++++++++---------------
 2 files changed, 22 insertions(+), 23 deletions(-)
Signature · 1 line
2.29.2