replace smp barriers in vhost with C11 atomic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | examples/vhost: relax memory ordering when enqueue/dequeueexamples/ | +4 | 1 reply | |
| 2/8 | examples/vhost_blk: replace smp with thread fenceexamples/ | +4 | 1 reply | |
| 3/8 | vhost: remove unnecessary smp barrier for desc flagslib/ | +0 | 1 reply | |
| 4/8 | vhost: remove unnecessary smp barrier for avail idxlib/ | +2 | 1 reply | |
| 5/8 | vhost: relax full barriers for desc flagslib/ | +3 | 1 reply | |
| 6/8 | vhost: relax full barriers for used idxlib/ | +2 | 1 reply | |
| 7/8 | vhost: replace smp with thread fence for packed vringlib/ | +5 | 1 reply | |
| 8/8 | vhost: replace smp with thread fence for control pathlib/ lib/ lib/ +1 more | +14 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Ruifeng Wang | Maxime Coquelin |
|---|---|---|
| 1/8 | R-b | R-b |
| 2/8 | R-b | |
| 3/8 | R-b | R-b |
| 4/8 | R-b | R-b |
| 5/8 | R-b | R-b |
| 6/8 | R-b | R-b |
| 7/8 | R-b | R-b |
| 8/8 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [dpdk-dev] [PATCH v1 0/8] replace smp barriers in vhost with C11 atomic
This patchset is to replace rte smp barriers in vhost with C11 atomic built-ins.
The rte_smp_*mb APIs provide full barrier functionality. However, many use cases do not require full barriers. To support such use cases, DPDK will adopt C11 barrier semantics and provide wrappers using C11 atomic built-ins.[1]
With this patchset, PVP case(vhost-user + virtio-user) has 9.8% perf uplift for the split in_order path and no perf degradation for the packed in_order path under 0.001% acceptable loss on ThunderX2 platform.
[1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst
Joyce Kong (8):
examples/vhost: relax memory ordering when enqueue/dequeue examples/vhost_blk: replace smp with thread fence
vhost: remove unnecessary smp barrier for desc flags
vhost: remove unnecessary smp barrier for avail idx
vhost: relax full barriers for desc flags
vhost: relax full barriers for used idx
vhost: replace smp with thread fence for packed vring
vhost: replace smp with thread fence for control path
examples/vhost/virtio_net.c | 12 ++++-------- examples/vhost_blk/vhost_blk.c | 8 ++++---- lib/librte_vhost/vdpa.c | 4 ++-- lib/librte_vhost/vhost.c | 18 +++++++++--------- lib/librte_vhost/vhost.h | 6 +++--- lib/librte_vhost/vhost_user.c | 2 +- lib/librte_vhost/virtio_net.c | 26 +++++++++++--------------- 7 files changed, 34 insertions(+), 42 deletions(-)
Signature · 1 line
2.29.2