Skip to content

net/tap: some fixes and refactorings

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net/tap: fix net_init_tap(): set ret on failure pathnet/tap.c+1 -00 replies
2/5net/tap: drop duplicated tap stubsnet/meson.build net/tap-bsd.c net/tap-open-stub.c +2 more+37 -1130 replies
3/5net/tap: tap_set_sndbuf(): return statusnet/tap-linux.c net/tap-stub.c net/tap.c +1 more+9 -62 replies
4/5net/tap: refactor and improve net_init_tap_one()include/net/vhost_net.h net/tap.c+53 -530 replies
5/5net/tap: net_init_tap_one(): fix net-client leak on failure pathnet/tap.c+8 -12 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/5
2/5
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] net/tap: some fixes and refactorings

Hi all. I have a work in progress around net/tap (and not sure, will it be done or we go another way), but some fixes and good refactoring I'd like to post anyway:

Vladimir Sementsov-Ogievskiy (5):
net/tap: fix net_init_tap(): set ret on failure path net/tap: drop duplicated tap stubs
net/tap: tap_set_sndbuf(): return status
net/tap: refactor and improve net_init_tap_one() net/tap: net_init_tap_one(): fix net-client leak on failure path

 include/net/vhost_net.h |   3 -
 net/tap_int.h           |   2 +-
 net/tap-bsd.c           |  53 ------------------
 net/tap-linux.c         |   5 +-
 net/tap-open-stub.c     |  34 ++++++++++++
 net/tap-solaris.c       |  53 ------------------
 net/tap-stub.c          |   9 +--
 net/tap.c               | 119 ++++++++++++++++++++++------------------
 net/meson.build         |   3 +
 9 files changed, 108 insertions(+), 173 deletions(-)
 create mode 100644 net/tap-open-stub.c
Signature · 1 line
2.28.0