drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest5 patches 1 replyIn review
- v54 patches 2 repliesSuperseded
- v43 patches 1 replySuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 2 replies | Superseded | |
| v2 | 1 patch | 1 reply | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | drivers/soc/litex: move generic accessors to litex.hdrivers/ include/ | +69 | 0 replies | |
| 2/5 | drivers/soc/litex: separate MMIO from subregister offset calculationinclude/ | +14 | 0 replies | |
| 3/5 | drivers/soc/litex: s/LITEX_REG_SIZE/LITEX_SUBREG_ALIGN/ginclude/ | +5 | 0 replies | |
| 4/5 | drivers/soc/litex: support 32-bit subregisters, 64-bit CPUsdrivers/ drivers/ include/ | +67 | 0 replies | |
| 5/5 | drivers/soc/litex: make 'litex_[set|get]_reg()' methods privatedrivers/ include/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.
Cover letter [PATCH v6 0/5] drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs
This series expands on commit 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver"), adding support for handling both 8- and 32-bit LiteX CSR (MMIO) subregisters, on both 32- and 64-bit CPUs.
Notes v6:
- split out s/LITEX_REG_SIZE/LITEX_SUBREG_ALIGN/g change into its own dedicated (cosmetic-only) patch (3/5).
- fixed typos in "main patch" (now 4/5) changelog.
- fixed typos in comments added via patch 5/5.
Notes v5:
- added patch (4/4) taking 'litex_[set|get]_reg()' private
- additional optimization of [_]litex_set_reg() in 3/4
Notes v4:
- improved "eloquence" of some 3/3 commit blurb paragraphs
- fixed instance of "disgusting" comment style :)
- litex_[get|set]_reg() now using size_t for 'reg_size' argument
- slightly tighter shift calculation in litex_set_reg()
Notes v3:
- split into smaller, more self-explanatory patches
- more detailed commit blurb for "main payload" (3/3) patch
- eliminate compiler warning on 32-bit architectures
Notes v2:
- fix typo (s/u32/u64/) in litex_read64().
Notes v1:
- LITEX_SUBREG_SIZE now provided by Kconfig.
- it's not LITEX_REG_SIZE, but rather LITEX_SUBREG_ALIGN!
- move litex_[get|set]_reg() to include/linux/litex.h and mark them as "static inline";
- redo litex_[read|write][8|16|32|64]() using litex_[get|set]_reg() (compiler should produce code as efficient as hardcoded shifts, but also automatically matching LITEX_SUBREG_SIZE).
Gabriel Somlo (5):
drivers/soc/litex: move generic accessors to litex.h drivers/soc/litex: separate MMIO from subregister offset calculation drivers/soc/litex: rename LITEX_REG_SIZE to LITEX_SUBREG_ALIGN drivers/soc/litex: support 32-bit subregisters, 64-bit CPUs drivers/soc/litex: make 'litex_[set|get]_reg()' methods private
drivers/soc/litex/Kconfig | 14 ++- drivers/soc/litex/litex_soc_ctrl.c | 76 +------------- include/linux/litex.h | 154 +++++++++++++++++++---------- 3 files changed, 119 insertions(+), 125 deletions(-)
Signature · 1 line
2.26.2