Skip to content

net: ipa: GSI interrupt handling fixes

Alex Elder lkml netdev oe-kbuild-all 1 version Applied

Status from this message: This series was applied to netdev/net.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: ipa: clear pending interrupts before enablingdrivers/net/ipa/gsi.c+12 -00 repliesApplied
2/3net: ipa: use state to determine channel command successdrivers/net/ipa/gsi.c+22 -210 repliesApplied
3/3net: ipa: use state to determine event ring command successdrivers/net/ipa/gsi.c+22 -120 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/3] net: ipa: GSI interrupt handling fixes

This series implements fixes for some issues related to handling interrupts when GSI channel and event ring commands complete.

The first issue is that the completion condition for an event ring or channel command could occur while the associated interrupt is disabled. This would cause the interrupt to fire when it is subsequently enabled, even if the condition it signals had already been handled. The fix is to clear any pending interrupt conditions before re-enabling the interrupt.

The second and third patches change how the success of an event ring or channel command is determined. These commands change the state of an event ring or channel. Previously the receipt of a completion interrupt was required to consider a command successful. Instead, a command is successful if it changes the state of the target event ring or channel in the way expected. This way the command can succeed even if the completion interrupt did not arrive while it was enabled.

-Alex

Alex Elder (3):
net: ipa: clear pending interrupts before enabling
net: ipa: use state to determine channel command success
net: ipa: use state to determine event ring command success

 drivers/net/ipa/gsi.c | 89 +++++++++++++++++++++++++++----------------
 1 file changed, 56 insertions(+), 33 deletions(-)
Signature · 1 line
2.20.1