Skip to content

RFC pc: support user provided NIC naming/indexing

Igor Mammedov qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5acpi: add aml_to_decimalstring() and aml_call6() helpershw/acpi/aml-build.c include/hw/acpi/aml-build.h+31 -00 replies
2/5tests: acpi: temporary whitelist DSDT changestests/qtest/bios-tables-test-allowed-diff.h+21 -00 replies
3/5pci: introduce apci-index property for PCI devicehw/acpi/pci.c hw/acpi/pcihp.c hw/i386/acpi-build.c +3 more+48 -20 replies
4/5pci: acpi: add _DSM method to PCI deviceshw/acpi/pci.c hw/i386/acpi-build.c include/hw/acpi/pci.h+97 -34 replies
5/5tests: acpi: update expected data filestests/data/acpi/pc/DSDT tests/data/acpi/pc/DSDT.acpihmat tests/data/acpi/pc/DSDT.bridge +18 more+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] pc: support user provided NIC naming/indexing

Series implements support for 'onboard' naming scheme for network interfaces (1), which is based on PCI firmware spec and lets user to explicitly specify index that will be used by guest to name network interface, ex:

    -device e1000,acpi-index=33

should make guest rename NIC name to 'eno33' where 'eno' is default prefix for this scheme.

Hope is that it will allow to simplify launching VMs from template disk images with different set VM configurations without need to reconfigure guest network intrfaces or risk of loosing network connectivity.

For more detailed description/examples see patches [3-4/5]

1)
https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/

Git repo for testing:
https://github.com/imammedo/qemu/branches acpi-index-rfc

Igor Mammedov (5):
acpi: add aml_to_decimalstring() and aml_call6() helpers
tests: acpi: temporary whitelist DSDT changes
pci: introduce apci-index property for PCI device
pci: acpi: add _DSM method to PCI devices
tests: acpi: update expected data files

 include/hw/acpi/aml-build.h                 |   3 +
 include/hw/acpi/pci.h                       |   1 +
 include/hw/acpi/pcihp.h                     |   7 +-
 include/hw/pci/pci.h                        |   1 +
 tests/qtest/bios-tables-test-allowed-diff.h |  21 +++++
 hw/acpi/aml-build.c                         |  28 +++++++
 hw/acpi/pci.c                               |  84 ++++++++++++++++++++
 hw/acpi/pcihp.c                             |  25 +++++-
 hw/i386/acpi-build.c                        |  31 +++++++-
 hw/pci/pci.c                                |   1 +
 tests/data/acpi/pc/DSDT                     | Bin 5065 -> 6023 bytes
 tests/data/acpi/pc/DSDT.acpihmat            | Bin 6390 -> 7348 bytes
 tests/data/acpi/pc/DSDT.bridge              | Bin 6924 -> 8689 bytes
 tests/data/acpi/pc/DSDT.cphp                | Bin 5529 -> 6487 bytes
 tests/data/acpi/pc/DSDT.dimmpxm             | Bin 6719 -> 7677 bytes
 tests/data/acpi/pc/DSDT.hpbridge            | Bin 5026 -> 5990 bytes
 tests/data/acpi/pc/DSDT.hpbrroot            | Bin 3084 -> 3177 bytes
 tests/data/acpi/pc/DSDT.ipmikcs             | Bin 5137 -> 6095 bytes
 tests/data/acpi/pc/DSDT.memhp               | Bin 6424 -> 7382 bytes
 tests/data/acpi/pc/DSDT.numamem             | Bin 5071 -> 6029 bytes
 tests/data/acpi/pc/DSDT.roothp              | Bin 5261 -> 6324 bytes
 tests/data/acpi/q35/DSDT                    | Bin 7801 -> 7863 bytes
 tests/data/acpi/q35/DSDT.acpihmat           | Bin 9126 -> 9188 bytes
 tests/data/acpi/q35/DSDT.bridge             | Bin 7819 -> 7911 bytes
 tests/data/acpi/q35/DSDT.cphp               | Bin 8265 -> 8327 bytes
 tests/data/acpi/q35/DSDT.dimmpxm            | Bin 9455 -> 9517 bytes
 tests/data/acpi/q35/DSDT.ipmibt             | Bin 7876 -> 7938 bytes
 tests/data/acpi/q35/DSDT.memhp              | Bin 9160 -> 9222 bytes
 tests/data/acpi/q35/DSDT.mmio64             | Bin 8932 -> 9024 bytes
 tests/data/acpi/q35/DSDT.numamem            | Bin 7807 -> 7869 bytes
 tests/data/acpi/q35/DSDT.tis                | Bin 8407 -> 8468 bytes
 31 files changed, 197 insertions(+), 5 deletions(-)
Signature · 1 line
2.27.0