Skip to content

fix tegra-hda on tegra30 devices

Peter Geis alsa-devel linux-clk linux-tegra lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v12 patches 8 repliesSuperseded

Changes in v2 from the cover letter

-Added ack and reviewed-by from Jon
-Updated fix to apply to tegra30-hda vice universally (Thanks Jon) -Updated commit to include comments from hardware team (Thanks Sameer) -Cleaned up commit messages

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2clk: tegra30: Add hda clock default rates to clock driverdrivers/clk/tegra/clk-tegra30.c+2 -02 replies
2/2ALSA: hda/tegra: fix tegra-hda on tegra30 socsound/pci/hda/hda_tegra.c+1 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJon HunterIon AgorriaSameer PujarTakashi IwaiThierry Reding
SeriesA-b
1/2A-b T-b A-b A-b
2/2R-b T-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] fix tegra-hda on tegra30 devices

The following patches fix tegra-hda on legacy tegra devices. Two issues were discovered preventing tegra-hda from functioning:
-The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function.
-The tegra-hda encounters an input/output error when opening a stream.

Since the only mainline device that used tegra-hda until recently was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices. We can apply it to the tegra30-hda device to resolve the issue across the board. Note that downstream devices used the spdif device instead of hda for hdmi audio. The spdif device lacks a driver on mainline.

-Checkpatch seems to have issues finding [1], but git show has no issue.
[1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194")

Changelog:

v2:
-Added ack and reviewed-by from Jon
-Updated fix to apply to tegra30-hda vice universally (Thanks Jon) -Updated commit to include comments from hardware team (Thanks Sameer) -Cleaned up commit messages

Peter Geis (2):
clk: tegra30: Add hda clock default rates to clock driver
ALSA: hda/tegra: fix tegra-hda on tegra30 soc

 drivers/clk/tegra/clk-tegra30.c | 2 ++
 sound/pci/hda/hda_tegra.c       | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1