Skip to content

bareudp: fix several issues

Taehee Yoo netdev 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyApplied
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Change reproducer script in 1/2 patch.
- Fix reproducer script in 2/2 patch.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2bareudp: set NETIF_F_LLTX flagdrivers/net/bareudp.c+1 -00 replies
2/2bareudp: Fix use of incorrect min_headroom sizedrivers/net/bareudp.c+1 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGuillaume Nault
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/2] bareudp: fix several issues

This patchset is to fix problems when bareudp is used nestedly.

1. If the NETIF_F_LLTX flag is not set, the lockdep warns about a possible deadlock scenario when bareudp interfaces are used nestedly. But, like other tunneling interfaces, bareudp doesn't need xmit lock. So, it sets NETIF_F_LLTTX.
Lockdep no more warns about a possible deadlock scenario.

2. bareudp interface calculates min_headroom when it sends a packet. When it calculates min_headroom, it uses the size of struct iphdr even the ipv6 packet is going to be sent.
It would result in a lack of headroom so eventually occurs kernel panic.

Changelog
v1 -> v2:
- Change reproducer script in 1/2 patch.
- Fix reproducer script in 2/2 patch.

Taehee Yoo (2):
bareudp: set NETIF_F_LLTX flag
bareudp: Fix use of incorrect min_headroom size

 drivers/net/bareudp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1