Skip to content

scan-build fixes

Alex Henrie alsa-devel 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/9conf: fix use after free in _snd_config_load_with_includesrc/conf.c+3 -11 reply
2/9ucm: fix bad frees in get_list0 and get_list20src/ucm/main.c+2 -21 reply
3/9rawmidi: fix memory leak in snd_rawmidi_virtual_opensrc/rawmidi/rawmidi_virt.c+2 -11 reply
4/9confmisc: fix memory leak in snd_func_concatsrc/confmisc.c+1 -12 replies
5/9timer: fix sizeof operator mismatch in snd_timer_query_hw_opensrc/timer/timer_query_hw.c+1 -11 reply
6/9pcm: remove dead assignments from snd_pcm_rate_(commit_area|grab_next_period)src/pcm/pcm_rate.c+0 -21 reply
7/9pcm_multi: remove dead assignment from _snd_pcm_multi_opensrc/pcm/pcm_multi.c+0 -11 reply
8/9pcm: fix undefined bit shift in bad_pcm_stateinclude/pcm.h src/pcm/pcm.c src/pcm/pcm_local.h+6 -23 replies
9/9conf: remove dead code from get_hexacharsrc/conf.c+1 -83 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] scan-build fixes

These defects were identified by scan-build
<https://clang-analyzer.llvm.org/scan-build.html>.

I hope that drawing attention to the problems helps even if you decide to fix some of them in different ways than I am proposing.

Happy holidays!

-Alex

Alex Henrie (9):
conf: fix use after free in _snd_config_load_with_include
ucm: fix bad frees in get_list0 and get_list20
rawmidi: fix memory leak in snd_rawmidi_virtual_open
confmisc: fix memory leak in snd_func_concat
timer: fix sizeof operator mismatch in snd_timer_query_hw_open
pcm: remove dead assignments from
snd_pcm_rate_(commit_area|grab_next_period)
pcm_multi: remove dead assignment from _snd_pcm_multi_open
pcm: fix undefined bit shift in bad_pcm_state
conf: remove dead code from get_hexachar

 include/pcm.h              |  4 +++-
 src/conf.c                 | 13 ++++---------
 src/confmisc.c             |  2 +-
 src/pcm/pcm.c              |  2 ++
 src/pcm/pcm_local.h        |  2 +-
 src/pcm/pcm_multi.c        |  1 -
 src/pcm/pcm_rate.c         |  2 --
 src/rawmidi/rawmidi_virt.c |  3 ++-
 src/timer/timer_query_hw.c |  2 +-
 src/ucm/main.c             |  4 ++--
 10 files changed, 16 insertions(+), 19 deletions(-)
Signature · 1 line
2.29.2.368.ge46b91665e.dirty