Skip to content

Fix perf build failures

Salvatore Bonaccorso linux-arm-kernel stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf cs-etm: Change tuple from traceID-CPU# to traceID-metadatatools/perf/util/cs-etm-decoder/cs-etm-decoder.c tools/perf/util/cs-etm.c tools/perf/util/cs-etm.h+31 -120 replies
2/2perf cs-etm: Move definition of 'traceid_list' global variable from header filetools/perf/util/cs-etm.c tools/perf/util/cs-etm.h+3 -30 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMathieu PoirierMike LeachThomas Backlund
1/2R-b
2/2R-b R-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 4.19.y only 0/2] Fix perf build failures

Hi Greg, Sasha and all,

This is a resubmit of the patches already done in
https://lore.kernel.org/stable/[email protected]/
and
https://lore.kernel.org/stable/[email protected]/

The issue can be explained as this. In

https://lore.kernel.org/stable/[email protected]/

on request 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable from header file") was queued back to 4.19.y to fix build failures for perf with more recent GCCs.

But for 4.19.y this was wrong because it missed to pick as well a dependency needed, and in turn it caused build failures with older GCC (8.3.0 as used in Debian stable in that case).

The commit was reverted in a later in 4.19.159.

It as though requested to try to allow as well compilation with more recent GCCs (while obviously not breaking older GCC builds) and found that the cause was just the missing dependency to pick up, namely pick 95c6fe970a01 ("perf
cs-etm: Change tuple from traceID-CPU# to traceID-metadata") before 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable from header file").

Regards,
Salvatore

Leo Yan (2):
perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata perf cs-etm: Move definition of 'traceid_list' global variable from
header file

 .../perf/util/cs-etm-decoder/cs-etm-decoder.c |  8 ++---
 tools/perf/util/cs-etm.c                      | 29 +++++++++++++++----
 tools/perf/util/cs-etm.h                      | 10 +++++--
 3 files changed, 33 insertions(+), 14 deletions(-)
Signature · 1 line
2.30.0.rc2