Skip to content

Improvements to nfsd stats

Amir Goldstein linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v12 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Cleanup unused stats counters (Bruce)
- Replace counters array hack with proper array (Chuck)
- Helpers to update both global and per-export stats

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nfsd: remove unused stats countersfs/nfsd/stats.c fs/nfsd/stats.h+16 -350 replies
2/3nfsd: protect concurrent access to nfsd stats countersfs/nfsd/netns.h fs/nfsd/nfs4proc.c fs/nfsd/nfscache.c +5 more+192 -533 replies
3/3nfsd: report per-export statsfs/nfsd/export.c fs/nfsd/export.h fs/nfsd/nfsctl.c +4 more+92 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Improvements to nfsd stats

Hi Bruce,

Per your request, I added a cleanup patch for unused counter.

Replaced the hacky counters array "union" with proper array and added helpers to update the counters to avoid human mistakes related to counter indices.

Thanks,
Amir.

Changes since v1:
- Cleanup unused stats counters (Bruce)
- Replace counters array hack with proper array (Chuck)
- Helpers to update both global and per-export stats

Amir Goldstein (3):
nfsd: remove unused stats counters
nfsd: protect concurrent access to nfsd stats counters
nfsd: report per-export stats

 fs/nfsd/export.c   |  68 +++++++++++++++++++++++----
 fs/nfsd/export.h   |  15 ++++++
 fs/nfsd/netns.h    |  23 +++++----
 fs/nfsd/nfs4proc.c |   2 +-
 fs/nfsd/nfscache.c |  52 +++++++++++++++------
 fs/nfsd/nfsctl.c   |   8 +++-
 fs/nfsd/nfsd.h     |   2 +-
 fs/nfsd/nfsfh.c    |   4 +-
 fs/nfsd/stats.c    | 114 +++++++++++++++++++++++++++++++--------------
 fs/nfsd/stats.h    |  96 +++++++++++++++++++++++++++++---------
 fs/nfsd/vfs.c      |   4 +-
 11 files changed, 292 insertions(+), 96 deletions(-)
Signature · 1 line
2.17.1