Skip to content

replace minstrel with minstrel_ht

Felix Fietkau linux-wireless 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 0 repliesNew
  2. v28 patches 0 repliesSuperseded
  3. v18 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- add cover letter
- fix uninitialized stack variable
- add extra patch to fix significant rounding error in tpt calculation

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9mac80211: minstrel_ht: clean up CCK codenet/mac80211/rc80211_minstrel_ht.c net/mac80211/rc80211_minstrel_ht.h+32 -270 replies
2/9mac80211: minstrel_ht: add support for OFDM rates on non-HT clientsnet/mac80211/rc80211_minstrel.h net/mac80211/rc80211_minstrel_ht.c net/mac80211/rc80211_minstrel_ht.h +1 more+224 -1160 replies
3/9mac80211: remove legacy minstrel rate controlnet/mac80211/Makefile net/mac80211/rc80211_minstrel.c net/mac80211/rc80211_minstrel.h +4 more+167 -9890 replies
4/9mac80211: minstrel_ht: remove old ewma based rate average codenet/mac80211/rc80211_minstrel_ht.c net/mac80211/rc80211_minstrel_ht.h+8 -240 replies
5/9mac80211: minstrel_ht: improve ampdu length estimationnet/mac80211/rc80211_minstrel_ht.c+27 -110 replies
6/9mac80211: minstrel_ht: improve sample rate selectionnet/mac80211/rc80211_minstrel_ht.c+3 -30 replies
7/9mac80211: minstrel_ht: fix max probability rate selectionnet/mac80211/rc80211_minstrel_ht.c+38 -90 replies
8/9mac80211: minstrel_ht: increase stats update intervalnet/mac80211/rc80211_minstrel_ht.c+1 -10 replies
9/9mac80211: minstrel_ht: fix rounding error in throughput calculationnet/mac80211/rc80211_minstrel_ht.c+3 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/9] replace minstrel with minstrel_ht

The legacy minstrel code is essentially unmaintained and receives only very little testing. In order to bring the significant algorithm improvements from minstrel_ht to legacy clients, this patch adds support for OFDM rates to minstrel_ht and removes the fallback to the legacy codepath.
This also makes it work much better on hardware with rate selection constraints, e.g. mt76.

Changes in v3:
- add cover letter
- fix uninitialized stack variable
- add extra patch to fix significant rounding error in tpt calculation

Changes in v2:
- fix using legacy-rates overhead in tpt calculation

Felix Fietkau (9):
mac80211: minstrel_ht: clean up CCK code
mac80211: minstrel_ht: add support for OFDM rates on non-HT clients
mac80211: remove legacy minstrel rate control
mac80211: minstrel_ht: remove old ewma based rate average code
mac80211: minstrel_ht: improve ampdu length estimation
mac80211: minstrel_ht: improve sample rate selection
mac80211: minstrel_ht: fix max probability rate selection
mac80211: minstrel_ht: increase stats update interval
mac80211: minstrel_ht: fix rounding error in throughput calculation

 net/mac80211/Makefile                      |   2 -
 net/mac80211/rc80211_minstrel.c            | 574 ---------------------
 net/mac80211/rc80211_minstrel.h            | 184 -------
 net/mac80211/rc80211_minstrel_debugfs.c    | 172 ------
 net/mac80211/rc80211_minstrel_ht.c         | 560 +++++++++++++-------
 net/mac80211/rc80211_minstrel_ht.h         |  96 +++-
 net/mac80211/rc80211_minstrel_ht_debugfs.c |  57 +-
 7 files changed, 482 insertions(+), 1163 deletions(-)
 delete mode 100644 net/mac80211/rc80211_minstrel.c
 delete mode 100644 net/mac80211/rc80211_minstrel.h
 delete mode 100644 net/mac80211/rc80211_minstrel_debugfs.c
Signature · 1 line
2.28.0