Skip to content

Remove last users of v4l2-clk and remove v4l2-clk

Ezequiel Garcia linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 11 repliesIn review
  2. v16 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6media: mach-pxa: Register the camera sensor fixed-rate clockarch/arm/mach-pxa/devices.c+8 -04 replies
2/6media: pxa_camera: Drop the v4l2-clk clock registerdrivers/media/platform/pxa_camera.c+1 -293 replies
3/6media: ov9640: Use the generic clock frameworkdrivers/media/i2c/ov9640.c drivers/media/i2c/ov9640.h+7 -101 reply
4/6media: mt9m111: Use the generic clock frameworkdrivers/media/i2c/mt9m111.c+7 -101 reply
5/6media: ov6650: Use the generic clock frameworkdrivers/media/i2c/ov6650.c+11 -171 reply
6/6media: Remove the legacy v4l2-clk APIDocumentation/driver-api/media/v4l2-clocks.rst Documentation/driver-api/media/v4l2-core.rst drivers/media/v4l2-core/Makefile +2 more+1 -4271 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchArnd BergmannJanusz KrzysztofikPetr Cvek
1/6A-b A-b
2/6A-b
3/6A-b
4/6R-b
5/6R-b R-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] Remove last users of v4l2-clk and remove v4l2-clk

The V4L2 temporary clock helper API is used by just one last capture driver, pxa-camera, which registers a dummy clock; and then by just a few sensor drivers, consuming clocks through the v4l2-clk API.

It's possible to convert these few last users, and so remove the v4l2-clk API, which hasn't been used for a few years.

The sensor drivers are already using the CCF API,
which v4l2-clk API uses as fallback.

To convert the pxa-camera driver, a fixed-rate clock is registered for the mach-based platforms that still exist, for mt9m111 to work (the only sensor that PXA currently registers).

Ezequiel Garcia (6):
media: mach-pxa: Register the camera sensor fixed-rate clock
media: pxa_camera: Drop the v4l2-clk clock register
media: ov9640: Use the generic clock framework
media: mt9m111: Use the generic clock framework
media: ov6650: Use the generic clock framework
media: Remove the legacy v4l2-clk API

 .../driver-api/media/v4l2-clocks.rst          |  31 --
 Documentation/driver-api/media/v4l2-core.rst  |   1 -
 arch/arm/mach-pxa/devices.c                   |   8 +
 drivers/media/i2c/mt9m111.c                   |  17 +-
 drivers/media/i2c/ov6650.c                    |  28 +-
 drivers/media/i2c/ov9640.c                    |  15 +-
 drivers/media/i2c/ov9640.h                    |   2 +-
 drivers/media/platform/pxa_camera.c           |  30 +-
 drivers/media/v4l2-core/Makefile              |   2 +-
 drivers/media/v4l2-core/v4l2-clk.c            | 321 ------------------
 include/media/v4l2-clk.h                      |  73 ----
 11 files changed, 35 insertions(+), 493 deletions(-)
 delete mode 100644 Documentation/driver-api/media/v4l2-clocks.rst
 delete mode 100644 drivers/media/v4l2-core/v4l2-clk.c
 delete mode 100644 include/media/v4l2-clk.h
Signature · 1 line
2.29.2