lazytime fix and cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest11 patches 3 repliesIn review
- v212 patches 28 repliesSuperseded
- v113 patches 23 repliesSuperseded
Changes in v3 from the cover letter
- Changed ext4 patch to add a helper function inode_is_dirtytime_only() to include/linux/fs.h.
- Dropped XFS cleanup patch, as it can be sent/applied separately.
- Added Reviewed-by's.
Patches in v3 No applies recorded yet
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Jan Kara |
|---|---|---|
| 1/11 | R-b | R-b |
| 2/11 | R-b | R-b |
| 3/11 | R-b | R-b |
| 4/11 | R-b | R-b |
| 5/11 | R-b | R-b |
| 6/11 | R-b | R-b |
| 7/11 | R-b | R-b |
| 8/11 | R-b | R-b |
| 9/11 | R-b | R-b |
| 10/11 | R-b | R-b |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 00/11] lazytime fix and cleanups
Hello,
Patch 1 fixes a bug in how __writeback_single_inode() handles lazytime expirations. I originally reported this last year
(https://lore.kernel.org/r/[email protected]) because it causes the FS_IOC_REMOVE_ENCRYPTION_KEY ioctl to not work properly, as the bug causes inodes to remain dirty after a sync.
It also turns out that lazytime on XFS is partially broken because it doesn't actually write timestamps to disk after a sync() or after dirtytime_expire_interval. This is fixed by the same fix.
This supersedes previously proposed fixes, including
https://lore.kernel.org/r/[email protected] and
https://lore.kernel.org/r/[email protected] from last year (which had some issues and didn't fix the XFS bug), and v1 of this patchset which took a different approach
(https://lore.kernel.org/r/[email protected]).
Patches 2-11 then clean up various things related to lazytime and writeback, such as clarifying the semantics of ->dirty_inode() and the inode dirty flags, and improving comments.
This patchset applies to v5.11-rc2.
Changed v2 => v3:
- Changed ext4 patch to add a helper function inode_is_dirtytime_only() to include/linux/fs.h.
- Dropped XFS cleanup patch, as it can be sent/applied separately.
- Added Reviewed-by's.
Changed v1 => v2:
- Switched to the fix suggested by Jan Kara, and dropped the
patches which introduced ->lazytime_expired().
- Fixed bugs in the fat and ext4 patches.
- Added patch "fs: improve comments for writeback_single_inode()".
- Reordered the patches a bit.
- Added Reviewed-by's.
Eric Biggers (11):
fs: fix lazytime expiration handling in __writeback_single_inode()
fs: correctly document the inode dirty flags
fs: only specify I_DIRTY_TIME when needed in generic_update_time()
fat: only specify I_DIRTY_TIME when needed in fat_update_time()
fs: don't call ->dirty_inode for lazytime timestamp updates
fs: pass only I_DIRTY_INODE flags to ->dirty_inode
fs: clean up __mark_inode_dirty() a bit
fs: drop redundant check from __writeback_single_inode()
fs: improve comments for writeback_single_inode()
gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync()
ext4: simplify i_state checks in __ext4_update_other_inode_time()
Documentation/filesystems/vfs.rst | 5 +- fs/ext4/inode.c | 20 +---- fs/f2fs/super.c | 3 - fs/fat/misc.c | 23 +++--- fs/fs-writeback.c | 132 +++++++++++++++++------------- fs/gfs2/file.c | 4 +- fs/gfs2/super.c | 2 - fs/inode.c | 38 +++++---- include/linux/fs.h | 33 ++++++-- 9 files changed, 146 insertions(+), 114 deletions(-)
base-commit: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
Signature · 8 lines
2.30.0 _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel