Skip to content

RFC: VMX: fix for disappearing L1->L2 event injection on L1 migration

Maxim Levitsky kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: VMX: create vmx_process_injected_eventarch/x86/kvm/vmx/vmx.c arch/x86/kvm/vmx/vmx.h+41 -230 replies
2/2KVM: nVMX: fix for disappearing L1->L2 event injection on L1 migrationarch/x86/kvm/vmx/nested.c+6 -63 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] RFC: VMX: fix for disappearing L1->L2 event injection on L1 migration

This is VMX version of the same issue as I reproduced on SVM.

Unlike SVM, this version has 2 pending issues to resolve.

1. This seems to break 'vmx' kvm-unit-test in
'error code <-> (!URG || prot_mode) [+]' case.

The test basically tries to do nested vm entry with unrestricted guest disabled, real mode, and for some reason that works without patch 2 of this series and it doesn't cause the #GP to be injected, but with this patch the test complains about unexpected #GP.
I suspect that this test case is broken, but this has to be investigated.

2. L1 MTF injections are lost since kvm has no notion of them, this is TBD to be fixed.

This was lightly tested on my nested migration test which no VMX sadly still crashes and burns on an (likely) unrelated issue.

Best regards,
Maxim Levitsky

Maxim Levitsky (2):
KVM: VMX: create vmx_process_injected_event
KVM: nVMX: fix for disappearing L1->L2 event injection on L1 migration

 arch/x86/kvm/vmx/nested.c | 12 ++++----
 arch/x86/kvm/vmx/vmx.c    | 60 ++++++++++++++++++++++++---------------
 arch/x86/kvm/vmx/vmx.h    |  4 +++
 3 files changed, 47 insertions(+), 29 deletions(-)
Signature · 1 line
2.26.2