Skip to content

kernel-shark: Visualization plugin tools

Yordan Karadzhov (VMware) linux-trace-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 0 repliesNew
  2. v26 patches 3 repliesSuperseded
  3. v16 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* Typo fixes in [patch 2]
* The missing signed-off-by of [patch 3] is restored.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6kernel-shark: Add KS_DOUBLE_SIZE macrosrc/libkshark-plugin.h src/libkshark.c tests/libkshark-tests.cpp+39 -90 replies
2/6kernel-shark: Add kshark_data_container to libksharksrc/libkshark.c src/libkshark.h tests/libkshark-tests.cpp+227 -00 replies
3/6kernel-shark: Add KS_DEFINE_PLUGIN_CONTEXT macrosrc/libkshark-plugin.h tests/libkshark-tests.cpp+73 -00 replies
4/6kernel-shark: Start using C++17CMakeLists.txt+6 -20 replies
5/6kernel-shark: Add plotting methods to KsPluginssrc/CMakeLists.txt src/KsPlugins.cpp src/KsPlugins.hpp+466 -10 replies
6/6kernel-shark: Speed-up the sched_events pluginsrc/CMakeLists.txt src/libkshark-plugin.h src/libkshark-tepdata.c +5 more+260 -5480 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchYordan Karadzhov (VMware)
1/6
2/6
3/6
4/6Signen-off-by
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] kernel-shark: Visualization plugin tools

We implement a general purpose instruments, that can be used to implement efficient (fast) visualization plugins. We also use the new instrumentation to optimize the sched_events plugin.

Changes in v3:
* Typo fixes in [patch 2]
* The missing signed-off-by of [patch 3] is restored.

Changes in v2:
* KS_DOUBLE_SIZE macro was simplified, based on the suggestion made by Steven in his review. A dedicated test case for the macro has been added.
* Bug fix in kshark_free_data_container().
* Bug fix in kshark_data_container_append().

Yordan Karadzhov (VMware) (6):
kernel-shark: Add KS_DOUBLE_SIZE macro
kernel-shark: Add kshark_data_container to libkshark
kernel-shark: Add KS_DEFINE_PLUGIN_CONTEXT macro
kernel-shark: Start using C++17
kernel-shark: Add plotting methods to KsPlugins
kernel-shark: Speed-up the sched_events plugin

 CMakeLists.txt              |   8 +-
 src/CMakeLists.txt          |   5 +-
 src/KsPlugins.cpp           | 416 ++++++++++++++++++++++++++++++++++++
 src/KsPlugins.hpp           |  48 +++++
 src/libkshark-plugin.h      |  59 +++++
 src/libkshark-tepdata.c     |  34 +++
 src/libkshark-tepdata.h     |   7 +
 src/libkshark.c             | 158 +++++++++++++-
 src/libkshark.h             |  43 ++++
 src/plugins/CMakeLists.txt  |  11 +-
 src/plugins/SchedEvents.cpp | 310 +++++++--------------------
 src/plugins/sched_events.c  | 393 +++++++++++-----------------------
 src/plugins/sched_events.h  |  50 ++---
 tests/libkshark-tests.cpp   |  89 ++++++++
 14 files changed, 1071 insertions(+), 560 deletions(-)
 create mode 100644 src/KsPlugins.cpp
Signature · 1 line
2.25.1