Skip to content

xfs: rework log quiesce to cover the log

Brian Foster linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 8 repliesIn review
  2. v19 patches 26 repliesSuperseded

Changes in v2 from the cover letter

- Return bool from xfs_log_need_covered().
- Reword patch 1 commit log.
- Apply review tags.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9xfs: sync lazy sb accounting on quiesce of read-only mountsfs/xfs/xfs_log.c fs/xfs/xfs_log.h fs/xfs/xfs_mount.c+22 -100 replies
2/9xfs: lift writable fs check up into log worker taskfs/xfs/xfs_log.c+8 -101 reply
3/9xfs: separate log cleaning from log quiescefs/xfs/xfs_log.c fs/xfs/xfs_log.h fs/xfs/xfs_super.c+9 -20 replies
4/9xfs: cover the log during log quiescefs/xfs/xfs_log.c fs/xfs/xfs_log.h+47 -42 replies
5/9xfs: don't reset log idle state on covering checkpointsfs/xfs/xfs_log.c+6 -31 reply
6/9xfs: fold sbcount quiesce logging into log coveringfs/xfs/xfs_log.c fs/xfs/xfs_mount.c fs/xfs/xfs_mount.h +1 more+18 -421 reply
7/9xfs: remove duplicate wq cancel and log force from attr quiescefs/xfs/xfs_super.c+0 -51 reply
8/9xfs: remove xfs_quiesce_attr()fs/xfs/xfs_mount.c fs/xfs/xfs_super.c+3 -231 reply
9/9xfs: cover the log on freeze instead of cleaning itfs/xfs/xfs_super.c+1 -21 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchAllison HendersonDarrick J. WongChristoph HellwigGao XiangBill O'Donnell
1/9R-b R-b R-b R-b
2/9R-b R-b R-b
3/9R-b R-b R-b
4/9R-b R-b R-b
5/9R-b R-b
6/9R-b R-b
7/9R-b R-b
8/9R-b R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] xfs: rework log quiesce to cover the log

Hi all,

Here's a v2 of the log quiesce rework to introduce and reuse log covering. This only has a couple minor tweaks from v1. Note again that patch 1 is an isolated bug fix related to the lazy sb accounting bug generic/388 was recently enhanced to reproduce.

Brian

v2:
- Return bool from xfs_log_need_covered().
- Reword patch 1 commit log.
- Apply review tags.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

Brian Foster (9):
xfs: sync lazy sb accounting on quiesce of read-only mounts
xfs: lift writable fs check up into log worker task
xfs: separate log cleaning from log quiesce
xfs: cover the log during log quiesce
xfs: don't reset log idle state on covering checkpoints
xfs: fold sbcount quiesce logging into log covering
xfs: remove duplicate wq cancel and log force from attr quiesce
xfs: remove xfs_quiesce_attr()
xfs: cover the log on freeze instead of cleaning it

 fs/xfs/xfs_log.c   | 128 ++++++++++++++++++++++++++++++++++++---------
 fs/xfs/xfs_log.h   |   4 +-
 fs/xfs/xfs_mount.c |  34 +-----------
 fs/xfs/xfs_mount.h |   1 -
 fs/xfs/xfs_super.c |  38 +-------------
 5 files changed, 109 insertions(+), 96 deletions(-)
Signature · 1 line
2.26.2