Skip to content

generic modify rte flow action support

Alexander Kozyrev dpdk-dev 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest2 patches 1 replyIn review
  2. v82 patches 2 repliesSuperseded
  3. v72 patches 2 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v62 patches0 repliesSuperseded
v52 patches3 repliesSuperseded
v42 patches3 repliesSuperseded
v32 patches1 replySuperseded
v22 patches1 replySuperseded
v11 patch10 repliesSuperseded

Changes in v9 from the cover letter

Minor documentation corrections.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ethdev: introduce generic modify rte flow actiondoc/guides/prog_guide/rte_flow.rst doc/guides/rel_notes/release_21_02.rst lib/librte_ethdev/rte_flow.c +1 more+168 -10 replies
2/2app/testpmd: add support for modify field flow actionapp/test-pmd/cmdline_flow.c+246 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchOri KamThomas MonjalonAjit Khaparde
1/2A-b A-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [dpdk-dev] [PATCH v9 0/2] generic modify rte flow action support

Implement a generic modify rte flow API as described in RFC:
http://patches.dpdk.org/patch/85384/

This API allows modifying a destination header field with data from a source header field. Number of bits to use from the source is specified. Tag, Mark or Metadata can also be used as a source/destination to allow saving/overwriting an arbitrary header field with a user-specified value. Alternatively, an immediate value can be provided by a user as a source.

Outermost/innermost packet fields (and Tag array elements) are accessible via the level parameter to facilitate the modification of encapsulated packet header fields. The offset parameter provides the flexibility to copy/set any part of a packet starting the specified packet header field.

Example of RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation for MLX5:
https://patchwork.dpdk.org/patch/86736/

---
v1: https://patchwork.dpdk.org/patch/86173/
Initial design.
v2: https://patchwork.dpdk.org/cover/86369/
Added testpmd support.
v3: https://patchwork.dpdk.org/cover/86442/
Made dst_type, src_type and width only mandatory parameters.
v4: https://patchwork.dpdk.org/cover/86488/
Renamed action to RTE_FLOW_ACTION_TYPE_COPY_FIELD.
v5: https://patchwork.dpdk.org/cover/86705/
Redesigned as RTE_FLOW_ACTION_TYPE_MODIFY_FIELD.
v6: https://patchwork.dpdk.org/cover/86715/
Fixed typos in documentation.
v7: https://patchwork.dpdk.org/cover/86718/
Fixed warnings.
v8: https://patchwork.dpdk.org/cover/86816/
Added doxygen comments.
v9:
Minor documentation corrections.

Alexander Kozyrev (2):
ethdev: introduce generic modify rte flow action app/testpmd: add support for modify field flow action

 app/test-pmd/cmdline_flow.c            | 246 +++++++++++++++++++++++++
 doc/guides/prog_guide/rte_flow.rst     |  66 +++++++
 doc/guides/rel_notes/release_21_02.rst |   8 +
 lib/librte_ethdev/rte_flow.c           |   2 +
 lib/librte_ethdev/rte_flow.h           |  93 +++++++++-
 5 files changed, 414 insertions(+), 1 deletion(-)
Signature · 1 line
2.24.1