ibmvnic: Use more consistent locking
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 12 repliesIn review
- v17 patches 8 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | ibmvnic: restore state in change-param resetdrivers/ | +1 | 1 reply | |
| 2/7 | ibmvnic: update reset function prototypesdrivers/ | +21 | 0 replies | |
| 3/7 | ibmvnic: avoid allocating rwi entriesdrivers/ drivers/ | +78 | 2 replies | |
| 4/7 | ibmvnic: switch order of checks in ibmvnic_resetdrivers/ | +6 | 0 replies | |
| 5/7 | ibmvnic: serialize access to work queuedrivers/ drivers/ | +16 | 3 replies | |
| 6/7 | ibmvnic: check adapter->state under state_lockdrivers/ drivers/ | +87 | 0 replies | |
| 7/7 | ibmvnic: add comments about state_lockdrivers/ drivers/ | +108 | 0 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dany Madden | Saeed Mahameed |
|---|---|---|
| Series | R-b | |
| 1/7 | R-b | |
| 2/7 | ||
| 3/7 | ||
| 4/7 | ||
| 5/7 | ||
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking
Use more consistent locking when reading/writing the adapter->state field. This patch set fixes a race condition during ibmvnic_open() where the adapter could be left in the PROBED state if a reset occurs at the wrong time. This can cause networking to not come up during boot and potentially require manual intervention in bringing up applications that depend on the network.
Changelog[v2] [Address comments from Jakub Kicinski]
- Fix up commit log for patch 5/7 and drop unnecessary variable
- Format Fixes line properly (no wrapping, no blank lines)
Sukadev Bhattiprolu (7):
ibmvnic: restore state in change-param reset
ibmvnic: update reset function prototypes
ibmvnic: avoid allocating rwi entries
ibmvnic: switch order of checks in ibmvnic_reset
ibmvnic: serialize access to work queue
ibmvnic: check adapter->state under state_lock
ibmvnic: add comments about state_lock
drivers/net/ethernet/ibm/ibmvnic.c | 347 ++++++++++++++++++++--------- drivers/net/ethernet/ibm/ibmvnic.h | 70 +++++- 2 files changed, 306 insertions(+), 111 deletions(-)
Signature · 1 line
2.26.2