Skip to content

Add support for SDM845 Camera Subsystem

Robert Foss linux-arm-kernel linux-arm-msm linux-devicetree linux-media lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17media: camss: Fix comment using wrong function namedrivers/media/platform/qcom/camss/camss-vfe.c+1 -12 replies
2/17media: camss: Fix vfe_isr comment typodrivers/media/platform/qcom/camss/camss-vfe-4-1.c drivers/media/platform/qcom/camss/camss-vfe-4-7.c+2 -22 replies
3/17media: camss: Add CAMSS_845 camss versiondrivers/media/platform/qcom/camss/camss.h+1 -00 replies
4/17media: camss: Make ISPIF subdevice optionaldrivers/media/platform/qcom/camss/camss-ispif.c drivers/media/platform/qcom/camss/camss-ispif.h drivers/media/platform/qcom/camss/camss.c +1 more+160 -1024 replies
5/17media: camss: Refactor VFE HW version supportdrivers/media/platform/qcom/camss/Makefile drivers/media/platform/qcom/camss/camss-vfe-4-1.c drivers/media/platform/qcom/camss/camss-vfe-4-7.c +5 more+2241 -10352 replies
6/17media: camss: Add support for VFE hardware version Titan 170drivers/media/platform/qcom/camss/Makefile drivers/media/platform/qcom/camss/camss-vfe-170.c drivers/media/platform/qcom/camss/camss-vfe.c +3 more+1034 -202 replies
7/17media: camss: Add missing format identifiersdrivers/media/platform/qcom/camss/camss-csid.h+50 -00 replies
8/17media: camss: Refactor CSID HW version supportdrivers/media/platform/qcom/camss/Makefile drivers/media/platform/qcom/camss/camss-csid-4-1.c drivers/media/platform/qcom/camss/camss-csid-4-7.c +2 more+897 -5900 replies
9/17media: camss: Add support for CSID hardware version Titan 170drivers/media/platform/qcom/camss/Makefile drivers/media/platform/qcom/camss/camss-csid-170.c drivers/media/platform/qcom/camss/camss-csid.c +2 more+671 -00 replies
10/17media: camss: Add support for CSIPHY hardware version Titan 170drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c drivers/media/platform/qcom/camss/camss-csiphy.c drivers/media/platform/qcom/camss/camss.c+290 -320 replies
11/17media: camss: Remove per VFE power domain togglingdrivers/media/platform/qcom/camss/camss-ispif.c drivers/media/platform/qcom/camss/camss-vfe.c drivers/media/platform/qcom/camss/camss.c +1 more+60 -640 replies
12/17media: dt-bindings: media: qcom,camss: Add bindings for SDM845 camssDocumentation/devicetree/bindings/media/qcom,camss.txt+40 -111 reply
13/17media: camss: Enable SDM845drivers/media/platform/qcom/camss/camss.c drivers/media/platform/qcom/camss/camss.h+21 -20 replies
14/17arm64: defconfig: Build Qcom CAMSS as modulearch/arm64/configs/defconfig+1 -00 replies
15/17arm64: dts: sdm845: Add CAMSS ISP nodearch/arm64/boot/dts/qcom/sdm845.dtsi+151 -00 replies
16/17arm64: dts: sdm845-db845c: Add CAMSS ISP nodearch/arm64/boot/dts/qcom/sdm845-db845c.dts+12 -02 replies
17/17arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISParch/arm64/boot/dts/qcom/sdm845-db845c.dts+15 -30 replies

Reviews trailers per patch

1 of 17 patches has a Reviewed-by or Acked-by.

PatchBjorn Andersson
1/17
2/17R-b
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 00/17] Add support for SDM845 Camera Subsystem

This series implements support for the camera subsystem found in the SDM845 SOCs and the Titan 170 ISP. The support is partial in that it implements CSIPHY, CSID, and partial VFE support.

The Titan generation of the ISP diverges a fair amount from the design of the previous architecture generation, CAMSS. As a result some pretty invasive refactoring is done in this series. It also means that at this time we're unable to implement support for all of the IP blocks contained. This is due to a combination of legal considerations with respect to the IP and its owner Qualcomm and time & man hour constrains on the Linaro side.

The CSIPHY (CSI Physical Layer) & CSID (CSI Decoder) support is complete, but the VFE (Video Front End, which is referred to as IFE (Image Front End) in the Titan generation of ISPs) only has support for the RDI (Raw Dump Interface) which allows the raw output of the CSID to be written to memory.

The 2nd interface implemented in the VFE silicon is the PIX interface, and camss does not support it for this generation of ISPs. The reason for this is that the PIX interface is used for sending image data to the BPS (Bayer Processing Section) & IPE (Image Processing Engine), but both of these units are beyond the scope of enabling basic ISP functionality for the SDM845.

Since the Titan architecture generation diverges quite a bit from the CAMSS generation, a lot of pretty major refactoring is carried out in this series. Both the CSID & VFE core paths are made more general and hardware version specific parts are broken out. The CSIPHY didn't require quite as radical changes and therefore keeps its current form.

Tested on:
- Qcom RB3 / db845c + camera mezzanine, which is SDM845 based
- db410c + D3 Camera mezzanine, which is APQ8016 based

Branch:
- https://git.linaro.org/people/robert.foss/linux.git/log/?h=camss_sdm845_v1

Robert Foss (17):
media: camss: Fix comment using wrong function name
media: camss: Fix vfe_isr comment typo
media: camss: Add CAMSS_845 camss version
media: camss: Make ISPIF subdevice optional
media: camss: Refactor VFE HW version support
media: camss: Add support for VFE hardware version Titan 170
media: camss: Add missing format identifiers
media: camss: Refactor CSID HW version support
media: camss: Add support for CSID hardware version Titan 170
media: camss: Add support for CSIPHY hardware version Titan 170
media: camss: Remove per VFE power domain toggling
media: dt-bindings: media: qcom,camss: Add bindings for SDM845 camss
media: camss: Enable SDM845
arm64: defconfig: Build Qcom CAMSS as module
arm64: dts: sdm845: Add CAMSS ISP node
arm64: dts: sdm845-db845c: Add CAMSS ISP node
arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISP

 .../devicetree/bindings/media/qcom,camss.txt  |   51 +-
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    |   28 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |  151 +++
 arch/arm64/configs/defconfig                  |    1 +
 drivers/media/platform/qcom/camss/Makefile    |    6 +
 .../platform/qcom/camss/camss-csid-170.c      |  602 +++++++++
 .../platform/qcom/camss/camss-csid-4-1.c      |  338 +++++
 .../platform/qcom/camss/camss-csid-4-7.c      |  406 ++++++
 .../media/platform/qcom/camss/camss-csid.c    |  620 +--------
 .../media/platform/qcom/camss/camss-csid.h    |  177 ++-
 .../qcom/camss/camss-csiphy-3ph-1-0.c         |  182 ++-
 .../media/platform/qcom/camss/camss-csiphy.c  |   66 +-
 .../media/platform/qcom/camss/camss-ispif.c   |  147 ++-
 .../media/platform/qcom/camss/camss-ispif.h   |    3 +-
 .../media/platform/qcom/camss/camss-vfe-170.c |  808 ++++++++++++
 .../media/platform/qcom/camss/camss-vfe-4-1.c |  119 +-
 .../media/platform/qcom/camss/camss-vfe-4-7.c |  240 ++--
 .../media/platform/qcom/camss/camss-vfe-4-8.c | 1166 +++++++++++++++++
 .../platform/qcom/camss/camss-vfe-gen1.c      |  760 +++++++++++
 .../platform/qcom/camss/camss-vfe-gen1.h      |  110 ++
 drivers/media/platform/qcom/camss/camss-vfe.c |  838 +-----------
 drivers/media/platform/qcom/camss/camss-vfe.h |  118 +-
 .../media/platform/qcom/camss/camss-video.c   |  100 ++
 drivers/media/platform/qcom/camss/camss.c     |  421 ++++--
 drivers/media/platform/qcom/camss/camss.h     |   17 +-
 25 files changed, 5630 insertions(+), 1845 deletions(-)
 create mode 100644 drivers/media/platform/qcom/camss/camss-csid-170.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-csid-4-1.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-csid-4-7.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-170.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-4-8.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-gen1.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-gen1.h
Signature · 1 line
2.27.0