Skip to content

power: fix make build for power apps

David Hunt dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 5 repliesIn review

v2 changes from the cover letter

- re-worked from monolithic patch to a 6 patch patchset for easier review

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchAnatoly BurakovDavid Marchand
SeriesA-b A-b A-b A-b A-b A-b A-b A-b A-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 0/6] power: fix make build for power apps

The power example applications that uses the virtio-serial method of communication cannot currently be built with make, and can only be built using meson/ninja.

The guest channel message definitions and functions in guest_channel.h are needed by applications and need to be made public.

This worked pre-20.11, but now with all the meson/ninja changes, making these apps externally no longer works. To fix, we need to move the header file with the API definitions for the channel commands public, and rename the functions accordingly.

The main change is to rename channel_commands.h to rte_power_guest_channel.h so that it gets picked up by the installer and copied to /usr/local/include. Other changes include renaming #defines to have RTE_ at the beginning instead of CPU_. Finally we refactor the code to work with those changes.

---
v2 changes
- re-worked from monolithic patch to a 6 patch patchset for easier review

[PATCH v2 1/6] power: create guest channel public header file [PATCH v2 2/6] power: make channel msg functions public [PATCH v2 3/6] power: rename public structs
[PATCH v2 4/6] power: rename defines
[PATCH v2 5/6] power: add new header file to export list [PATCH v2 6/6] power: clean up includes