Skip to content

power: fix make build for power apps

David Hunt dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 1 replyIn review
  2. v46 patches 11 repliesApplied
  3. v36 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v26 patches2 repliesSuperseded

Changes in v5 from the cover letter

- moved version.map additions from patch 3 to patch 2

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6power: create guest channel public header fileexamples/vm_power_manager/channel_manager.c examples/vm_power_manager/channel_monitor.c examples/vm_power_manager/channel_monitor.h +6 more+12 -130 replies
2/6power: make channel msg functions publiclib/librte_power/guest_channel.h lib/librte_power/rte_power_guest_channel.h lib/librte_power/version.map+55 -390 replies
3/6power: rename public structsexamples/vm_power_manager/channel_monitor.c examples/vm_power_manager/channel_monitor.h examples/vm_power_manager/guest_cli/main.c +6 more+73 -730 replies
4/6power: rename definesexamples/vm_power_manager/channel_monitor.c examples/vm_power_manager/channel_monitor.h examples/vm_power_manager/guest_cli/main.c +5 more+155 -1400 replies
5/6power: add new header file to export listlib/librte_power/meson.build+2 -10 replies
6/6power: clean up includesexamples/vm_power_manager/channel_manager.c examples/vm_power_manager/channel_monitor.c examples/vm_power_manager/channel_monitor.h +8 more+4 -140 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchAnatoly Burakov
1/6
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps

The guest channel message definitions and functions in guest_channel.h are needed by applications and need to be made public.

This worked pre-20.11, but now with all the meson/ninja changes, making these apps externally no longer works. To fix, we need to move the header file with the API definitions for the channel commands public, and rename the functions accordingly.

The main change is to rename channel_commands.h to rte_power_guest_channel.h so that it gets picked up by the installer and copied to /usr/local/include. Other changes include renaming #defines to have RTE_ at the beginning instead of CPU_. Finally we refactor the code to work with those changes.

---
v2 changes
- re-worked from monolithic patch to a 6 patch patchset for easier review
v3 changes
- Ensure both functions added to the API are tagged as experimental
v4 changes
- add @internal tag on 2 functions for Doxygen
- add @warning EXPERIMENTAL tag on 2 functions for Doxygen
- improve description of lcore param in API docs
- Improve maintainability sizeof's
- add the 2 added functions to the version.map file
v5 changes
- moved version.map additions from patch 3 to patch 2

[v5 1/6] power: create guest channel public header file [v5 2/6] power: make channel msg functions public [v5 3/6] power: rename public structs
[v5 4/6] power: rename defines
[v5 5/6] power: add new header file to export list [v5 6/6] power: clean up includes