Skip to content

rtlwifi: fix bool comparison in expressions

Aditya Srivastava linux-kernel-mentees linux-wireless lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rtlwifi: rtl_pci: fix bool comparison in expressionsdrivers/net/wireless/realtek/rtlwifi/ps.c+2 -22 replies
2/5rtlwifi: rtl8192c-common: fix bool comparison in expressionsdrivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c+2 -20 replies
3/5rtlwifi: rtl8188ee: fix bool comparison in expressionsdrivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c+6 -60 replies
4/5rtlwifi: rtl8192se: fix bool comparison in expressionsdrivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c+2 -20 replies
5/5rtlwifi: rtl8821ae: fix bool comparison in expressionsdrivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] rtlwifi: fix bool comparison in expressions

This patch series fixes the bool comparison in conditional expressions for all the drivers in rtlwifi.

There are certain conditional expressions in rtlwifi drivers, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the condition, rather than comparing with true/false

E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c, "if (mac->act_scanning == true)" can be replaced with "if (mac->act_scanning)"

Fix all such expressions with the bool variables appropriately for all the drivers in rtlwifi

* The changes made are compile tested.
* The patches apply perfectly on next-20210108

Aditya Srivastava (5):
rtlwifi: rtl_pci: fix bool comparison in expressions
rtlwifi: rtl8192c-common: fix bool comparison in expressions
rtlwifi: rtl8188ee: fix bool comparison in expressions
rtlwifi: rtl8192se: fix bool comparison in expressions
rtlwifi: rtl8821ae: fix bool comparison in expressions

 drivers/net/wireless/realtek/rtlwifi/ps.c                 | 4 ++--
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c       | 8 ++++----
 drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c       | 4 ++--
 drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4 ++--
 drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c       | 4 ++--
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c      | 8 ++++----
 6 files changed, 16 insertions(+), 16 deletions(-)
Signature · 6 lines
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees