rtlwifi: fix bool comparison in expressions
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rtlwifi: rtl_pci: fix bool comparison in expressionsdrivers/ | +2 | 2 replies | |
| 2/5 | rtlwifi: rtl8192c-common: fix bool comparison in expressionsdrivers/ | +2 | 0 replies | |
| 3/5 | rtlwifi: rtl8188ee: fix bool comparison in expressionsdrivers/ drivers/ | +6 | 0 replies | |
| 4/5 | rtlwifi: rtl8192se: fix bool comparison in expressionsdrivers/ | +2 | 0 replies | |
| 5/5 | rtlwifi: rtl8821ae: fix bool comparison in expressionsdrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] rtlwifi: fix bool comparison in expressions
This patch series fixes the bool comparison in conditional expressions for all the drivers in rtlwifi.
There are certain conditional expressions in rtlwifi drivers, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the condition, rather than comparing with true/false
E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c, "if (mac->act_scanning == true)" can be replaced with "if (mac->act_scanning)"
Fix all such expressions with the bool variables appropriately for all the drivers in rtlwifi
* The changes made are compile tested.
* The patches apply perfectly on next-20210108
Aditya Srivastava (5):
rtlwifi: rtl_pci: fix bool comparison in expressions
rtlwifi: rtl8192c-common: fix bool comparison in expressions
rtlwifi: rtl8188ee: fix bool comparison in expressions
rtlwifi: rtl8192se: fix bool comparison in expressions
rtlwifi: rtl8821ae: fix bool comparison in expressions
drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 8 ++++---- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 8 ++++---- 6 files changed, 16 insertions(+), 16 deletions(-)
Signature · 6 lines
2.17.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees